Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 10 Sep 2014 00:21:34 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 181301] [NEW PORT] net/kamailio: Very fast and configurable open source SIP proxy
Message-ID:  <bug-181301-13-eGCDUPZJkl@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-181301-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-181301-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=181301

--- Comment #10 from olivermahmoudi@gmail.com ---
Just added Makefile.diff to take care of the changes you suggested:


1) this has to be fixed:
WARN: Makefile: [92]: NOPORTDOCS found.  Consider using PORT_OPTIONS:MDOCS.

Fixed

2) CFLAGS+=    -Wall -Werror
NEVER, NEVER, NEVER intentionally add -Werror.  We *REMOVE* that flag when we
see it

Fixed

3) COMMENT=    A very fast and configurable open source SIP proxy
Never start a COMMENT with "A", "The", "An", or the name of the port

Fixed

4) XWRKSRC=        ${WRKDIR}/${PORTNAME}-${PORTVERSION}
Why are you doing this?  That's the default value of WRKSRC

Kept this after all, since commenting it out, fails the built.

5) XPLIST_SUB+=    MYSQL=""
X.else
XPLIST_SUB+=    MYSQL="@comment "

This is ancient use of options, use the new OPTIONS_SUB please (review porters
handbook on OPTIONS)

The program's configure stage is non standard and options are passed on a
pre-build stage to prepare the built. Checked back on this issued with the
ports mailing list. Their feedback was that it is still OK to keep it that 
way since the new way of setting up the options won't solve my special scenario
here.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-181301-13-eGCDUPZJkl>