From owner-cvs-all@FreeBSD.ORG  Sat Jan 14 09:27:42 2012
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3888C106566C;
	Sat, 14 Jan 2012 09:27:42 +0000 (UTC)
	(envelope-from sunpoet@sunpoet.net)
Received: from sunpoet.net (sunpoet.net [220.133.12.240])
	by mx1.freebsd.org (Postfix) with ESMTP id B8ED98FC08;
	Sat, 14 Jan 2012 09:27:41 +0000 (UTC)
Received: by sunpoet.net (Postfix, from userid 1000)
	id C24E924F3; Sat, 14 Jan 2012 17:27:33 +0800 (CST)
Date: Sat, 14 Jan 2012 17:27:33 +0800
From: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>
To: Alex Dupre <ale@FreeBSD.org>
Message-ID: <20120114092733.GA45406@bonjour.sunpoet.net>
References: <201201130917.q0D9HfbF078269@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <201201130917.q0D9HfbF078269@repoman.freebsd.org>
Organization: The FreeBSD Project
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/print/pdflib Makefile pkg-plist
 ports/print/pdflib/files patch-configure ports/print/pdflib-perl Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Jan 2012 09:27:42 -0000

On Fri, Jan 13, 2012 at 09:17:41AM +0000, Alex Dupre wrote:
> ale         2012-01-13 09:17:41 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     print/pdflib         Makefile pkg-plist 
>     print/pdflib-perl    Makefile 
>   Added files:
>     print/pdflib/files   patch-configure 
>   Log:
>   - Add forgotten patch
>   - Switch to OPTIONS
>   - Add Java bindings [1]
>   
>   Submitted by:   Oliver Brandmueller <ob@e-Gitt.NET> [1]
>   
>   Revision  Changes    Path
>   1.4       +1 -1      ports/print/pdflib-perl/Makefile
>   1.61      +29 -9     ports/print/pdflib/Makefile
>   1.9       +12 -0     ports/print/pdflib/files/patch-configure (new)
>   1.22      +5 -0      ports/print/pdflib/pkg-plist

Hi Alex,

I was confused by the conditional PERL OPTIONS.

.if defined(WITH_PERL) 
OPTIONS=        PERL "Build perl bindings" on 
.else 
OPTIONS=        PERL "Build perl bindings" off 
.endif 

If WITH_PERL defined somewhere (pdflib-perl, make.conf or portconf),
the perl option should already be turned on by options framework. It
seems that a default-off perl option (line 4) is enough.

Regards,
-- 
   Sunpoet Po-Chuan Hsieh <sunpoet at sunpoet.net> <sunpoet at FreeBSD.org>
           4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B
                             http://people.FreeBSD.org/~sunpoet/pgpkeys.txt