From owner-svn-src-all@FreeBSD.ORG Sun Oct 16 17:39:56 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 679791065670 for ; Sun, 16 Oct 2011 17:39:56 +0000 (UTC) (envelope-from bounces+73574-8822-svn-src-all=freebsd.org@sendgrid.me) Received: from o1.shared.sendgrid.net (o1.shared.sendgrid.net [74.63.231.244]) by mx1.freebsd.org (Postfix) with SMTP id 1FA558FC08 for ; Sun, 16 Oct 2011 17:39:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.info; h= message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; s=smtpapi; bh=/2ucajSE+27ftwV1d9J2o3nGWgo=; b=X5IzVz9euvzREKqVSdCxiUIk6e0F pusGmNsRbsY0+R+Ok3CXnWpeL27tvSlBQftRxchgbSPt+zKh+VvMmUgsDWlCywKR j1gOXPyO/hWqY3W+DwdUKkA2dPuHhXR1w9cak2qYSyUsVe6ZL1heyy7Yy76iuSmC n2zJRIkyFomX+f8= Received: by 10.4.35.204 with SMTP id mf47.16553.4E9B12A51 Sun, 16 Oct 2011 12:21:41 -0500 (CDT) Received: from mail.tarsnap.com (unknown [10.9.180.5]) by mi11 (SG) with ESMTP id 4e9b12a5.53cd.3a1a4de for ; Sun, 16 Oct 2011 12:21:41 -0500 (CST) Received: (qmail 55642 invoked from network); 16 Oct 2011 17:19:22 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by mail.tarsnap.com with ESMTP; 16 Oct 2011 17:19:22 -0000 Received: (qmail 77746 invoked from network); 16 Oct 2011 17:21:12 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by clamshell.daemonology.net with SMTP; 16 Oct 2011 17:21:12 -0000 Message-ID: <4E9B1287.4050507@freebsd.org> Date: Sun, 16 Oct 2011 10:21:11 -0700 From: Colin Percival User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:6.0.2) Gecko/20110914 Thunderbird/6.0.2 MIME-Version: 1.0 To: Ed Schouten References: <201110140724.p9E7OmMB052118@svn.freebsd.org> In-Reply-To: <201110140724.p9E7OmMB052118@svn.freebsd.org> X-Enigmail-Version: undefined Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Sendgrid-EID: A6W2xSVPHetogaU8rnzccWwgBYtN+QvIzXyjfe/10PEZF+cs4LtmiSxPsZymrCYDe7WtdHSyo8HH6pLYDA4m6UCuEEqmexMb8o995pzmQMbFFXrBinOuP7oUY2TjAYz3uphWSKMRAlrQYj1K32GwMGlnV2zvfW0x7rFoOe3WsHk= Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r226359 - head/usr.bin/look X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Oct 2011 17:39:56 -0000 On 10/14/11 00:24, Ed Schouten wrote: > Log: > Build look(1) with WARNS=6. > > - if (sb.st_size > SIZE_T_MAX) > + if (sb.st_size > (off_t)SIZE_T_MAX) > errx(2, "%s: %s", file, strerror(EFBIG)); This might make look(1) build, but on a 64-bit machine it also makes look(1) fail with "File too large" whenever it's larger than (int64_t)(UINT64_MAX) = -1 bytes long. Please fix. :-) -- Colin Percival Security Officer, FreeBSD | freebsd.org | The power to serve Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid