From nobody Wed Apr 15 14:48:38 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fwkY35JkFz6Z00l; Wed, 15 Apr 2026 14:48:39 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fwkY34WKcz3tPf; Wed, 15 Apr 2026 14:48:39 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776264519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8H+oZr4xxHUwwVxroWdcR166x5U0CkS9y5osxQ34Q0U=; b=hRqnD1xyJ0qFONKuXIEM3CBag0U8zuerPn6cibL99K1l9u5g0OGGiZQfyWfHNW/qxspyPh WYTs48JyPDDLogfCpTGYhnOZ5f5pYa9/fW4W4QLnM+dH9lVBx5z9MAjnv//5g6jSbTAs02 Fif58UEaS8kTWE5tlXw/UFce+71NCywgi9p18XqxryJZuzmifgoj+sumgxss4wgzHjswFe xUnt2R0U/VnvhkWSjy+625tBPD+1bg2HBqbzaaaM/UPkHdvaDtpWFoRs77awYr5dU3G+NF OQSxYusas+MOWsY4J4ziKIqs20JLsnZsglMOB5RhHQcNgazk/rctYLkn/hNZOw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776264519; a=rsa-sha256; cv=none; b=UJ7gOYF+N2xC3DAQHgPByU/Q5Lq3zqaILRolNfUJDeb6VR8wyDdS5LHQCAmwZ7MtLDWFkf RkCF5WczUmqL4Ipjx0z7/U83eHsgonnmuJyiyK3YLVasamKgpPcQ7NKT8JjKeUE4IaqBWz wKPQd3kJ84PLQEvk6ib5DhHxnMs5nCxUmuLYqwb4CPRarrJsgQY+gQzzXAWKimo/lmMj20 zQ64iLt8Z8nsltITvv4U2TZQkqFEBb6rnoR6G0lcn9uBV3xzBM6MooJlp4tvp5EElGFtsq BXLNRqXKUyA9R0K+MM6RijM8h+5ge6k0ZJIzS8KBA9E2wjMXv4EmHdLFtdFjtQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776264519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8H+oZr4xxHUwwVxroWdcR166x5U0CkS9y5osxQ34Q0U=; b=qVCLGS7g4lbthuPnNxeS79VeuKMB5MCaQm5uD9HSeDyxfTyF0VN027k37OAUPXpA3RQesd u4XVbMOEFoTzBt1j0AQEA7FuO+TfM+9Xb+00aZFBHn+wZn8SVgbeMfWkK5SXMn1iEFRPkq 0qsseozRHCWyQWJ+IeoQ14y/v99oM3bAUu1UIC/RuGFPl6Jb0EUk5GYCGSRlQigTc8yIFI ZIOuLuNQkXHg/X06LfCvQG2IOOQeIO01GjMgOX1W+lq1HdFf8iN/g+VYXRWRv+IxpGBJMU hQJwrczQZW4UKpNJvl3RjFVecppfsUnzvIrGyny3O4EI7giMtYPSCfokjOEcyQ== Received: from [IPV6:2601:5c0:4202:5670:a48b:e56:f352:935f] (unknown [IPv6:2601:5c0:4202:5670:a48b:e56:f352:935f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4fwkY32SznzqMK; Wed, 15 Apr 2026 14:48:39 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <45629508-bfcb-4161-8913-470539b479ad@FreeBSD.org> Date: Wed, 15 Apr 2026 10:48:38 -0400 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 4fadf2466468 - main - tcp_close: Use in6_pcbdisconnect for INET6 sockets Content-Language: en-US To: Gleb Smirnoff , np@freebsd.org Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <69de895e.398d0.7253ff8b@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/14/26 18:13, Gleb Smirnoff wrote: > On Tue, Apr 14, 2026 at 06:37:18PM +0000, John Baldwin wrote: > J> The branch main has been updated by jhb: > J> > J> URL: https://cgit.FreeBSD.org/src/commit/?id=4fadf2466468dd6dcb6cf9e3739ed696a18c1bb4 > J> > J> commit 4fadf2466468dd6dcb6cf9e3739ed696a18c1bb4 > J> Author: John Baldwin > J> AuthorDate: 2026-04-14 18:07:51 +0000 > J> Commit: John Baldwin > J> CommitDate: 2026-04-14 18:07:51 +0000 > J> > J> tcp_close: Use in6_pcbdisconnect for INET6 sockets > J> > J> This also fixes the LINT-NOINET builds. > J> > J> Fixes: 40dbb06fa73c ("inpcb: retire INP_DROPPED and in_pcbdrop()") > > I think this change is also required. > > Almost sure it will fix panic observed by Navdeep. Yes, I had missed that when comparing the two. Given how similar this functions are, I wonder if in_pcbdisconnect() should be a shared method that just has a few AF-specific bits of code? The old in_pcbdrop() function was shared and not INET vs INET6 specific. -- John Baldwin