From owner-freebsd-bugs@FreeBSD.ORG Sun Sep 11 13:00:40 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3239016A41F for ; Sun, 11 Sep 2005 13:00:40 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2B8AD43D46 for ; Sun, 11 Sep 2005 13:00:38 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j8BD0bCa057481 for ; Sun, 11 Sep 2005 13:00:37 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j8BD0bnX057480; Sun, 11 Sep 2005 13:00:37 GMT (envelope-from gnats) Resent-Date: Sun, 11 Sep 2005 13:00:37 GMT Resent-Message-Id: <200509111300.j8BD0bnX057480@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Andre Albsmeier Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F19C416A41F for ; Sun, 11 Sep 2005 12:52:32 +0000 (GMT) (envelope-from Andre.Albsmeier@siemens.com) Received: from thoth.sbs.de (thoth.sbs.de [192.35.17.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id D150643D45 for ; Sun, 11 Sep 2005 12:52:31 +0000 (GMT) (envelope-from Andre.Albsmeier@siemens.com) Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by thoth.sbs.de (8.12.6/8.12.6) with ESMTP id j8BCqU2R012236 for ; Sun, 11 Sep 2005 14:52:30 +0200 Received: from ims.mchp.siemens.de (ims.mchp.siemens.de [139.25.31.39]) by mail2.siemens.de (8.12.6/8.12.6) with ESMTP id j8BCqUgY028673 for ; Sun, 11 Sep 2005 14:52:30 +0200 Received: from mail-ct.mchp.siemens.de (mail-ct.mchp.siemens.de [139.25.31.51]) by ims.mchp.siemens.de with ESMTP id j8BCqTJQ009276 for ; Sun, 11 Sep 2005 14:52:29 +0200 (MEST) Received: from curry.mchp.siemens.de (curry [139.25.42.7]) by mail-ct.mchp.siemens.de (8.12.11/8.12.11) with ESMTP id j8BCqTAV015953 for ; Sun, 11 Sep 2005 14:52:29 +0200 (MEST) Received: (from localhost) by curry.mchp.siemens.de (8.13.4/8.13.4) id j8BCqT1r041545 for FreeBSD-gnats-submit@freebsd.org; Sun, 11 Sep 2005 14:52:29 +0200 (CEST) Message-Id: <200509111252.j8BCqTJ8099342@curry.mchp.siemens.de> Date: Sun, 11 Sep 2005 14:52:29 +0200 (CEST) From: Andre Albsmeier To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/85970: 550.ipfwlimit does not delete tmp file X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2005 13:00:40 -0000 >Number: 85970 >Category: bin >Synopsis: 550.ipfwlimit does not delete tmp file >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Sep 11 13:00:36 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Andre Albsmeier >Release: FreeBSD 5.4-STABLE i386 >Organization: >Environment: System: FreeBSD 5.4-STABLE #2: Thu Aug 25 14:04:58 CEST 2005 >Description: Since rev 1.6.4.1 /etc/periodic/security/550.ipfwlimit creates a tmp file without deleting it if ipfw is not used. >How-To-Repeat: On a FreeBSD-5.4 box without ipfw: andre@bali:~>ls -l /tmp/security* -rw------- 1 root wheel 0 Sep 6 03:01 /tmp/security.BEMeBO7s -rw------- 1 root wheel 0 Sep 10 03:01 /tmp/security.OiHNQwdl -rw------- 1 root wheel 0 Sep 11 03:01 /tmp/security.PWShtLmE -rw------- 1 root wheel 0 Sep 8 03:01 /tmp/security.TpNslbC3 -rw------- 1 root wheel 0 Sep 9 03:01 /tmp/security.eRuWD2Aa -rw------- 1 root wheel 0 Sep 7 03:01 /tmp/security.sEnKe309 >Fix: --- 550.ipfwlimit.ORI Sun Sep 11 14:44:52 2005 +++ 550.ipfwlimit Sun Sep 11 14:45:20 2005 @@ -42,11 +42,11 @@ case "$daily_status_security_ipfwlimit_enable" in [Yy][Ee][Ss]) - TMP=`mktemp -t security` IPFW_LOG_LIMIT=`sysctl -n net.inet.ip.fw.verbose_limit 2> /dev/null` if [ $? -ne 0 ]; then exit 0 fi + TMP=`mktemp -t security` ipfw -a list | grep " log " | \ grep '^[[:digit:]]\+[[:space:]]\+[[:digit:]]\+' | \ awk -v limit="$IPFW_LOG_LIMIT" \ >Release-Note: >Audit-Trail: >Unformatted: