From nobody Thu Nov 10 00:42:13 2022 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N732K1fklz4dpsj for ; Thu, 10 Nov 2022 00:42:17 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Received: from www121.sakura.ne.jp (www121.sakura.ne.jp [153.125.133.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4N732J66hyz3kGk; Thu, 10 Nov 2022 00:42:16 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Authentication-Results: mx1.freebsd.org; none Received: from kalamity.joker.local (123-1-88-210.area1b.commufa.jp [123.1.88.210]) (authenticated bits=0) by www121.sakura.ne.jp (8.16.1/8.16.1/[SAKURA-WEB]/20201212) with ESMTPA id 2AA0gD11077092; Thu, 10 Nov 2022 09:42:13 +0900 (JST) (envelope-from junchoon@dec.sakura.ne.jp) Date: Thu, 10 Nov 2022 09:42:13 +0900 From: Tomoaki AOKI To: Mark Millard Cc: Warner Losh , "Patrick M. Hausen" , Alexander Leidinger , tsoome@freebsd.org, Li-Wen Hsu , current@freebsd.org Subject: Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script) Message-Id: <20221110094213.7c3d5a2bd2422b0b89ce4d12@dec.sakura.ne.jp> In-Reply-To: References: <202211070339.2A73dJlO027991@gitrepo.freebsd.org> <20221107121514.Horde.nulS9Wg1s3yzAsXXkuJRBa9@webmail.leidinger.net> <20221108105053.Horde.eqgFiBJe2ngGAj6BkXcv5-Z@webmail.leidinger.net> <20221109134610.Horde.JB7ibQTWprHbmIUfhg7JY7f@webmail.leidinger.net> <460205F9-5D59-4033-813B-C34E01BFD6C4@hausen.com> Organization: Junchoon corps X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd13.0) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4N732J66hyz3kGk X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:7684, ipnet:153.125.128.0/18, country:JP] X-ThisMailContainsUnwantedMimeParts: N On Wed, 9 Nov 2022 14:12:21 -0800 Mark Millard wrote: > On Nov 9, 2022, at 12:56, Warner Losh wrote: > > > On Wed, Nov 9, 2022 at 1:54 PM Patrick M. Hausen wrote: > > > > > Am 09.11.2022 um 21:51 schrieb Warner Losh : > > > Yes. For safety, boot loader upgrade is mandatory when you do a zpool upgrade of the root filesystem. > > > It was definitely needed in the OpenZFS jump, and we've had one or two other flag days since. > > > > That's a given and not a problem. What I fear from my understanding of this thread so far is > > that there might be a situation when I upgrade the zpool and the boot loader and the system > > ends up unbootable nonetheless. > > > > Possible or not? > > > > If all you do is upgrade, then no, modulo bugs that we've thankfully not had yet. > > I guess you mean FreeBSD upgrade, not zpool updgrade? > > For zpool upgrade after a main [so: 14] FreeBSD upgrade . . . > > As I understand it, com.delphix:head_errlog was not added to > the loader until after some folks had done a zpool upgrade > and then could not boot. The loader was updated in response > to the people's problem with trying to boot. > > Of course, this was main, not stable or releng/13.* or the > like. There is more control over the staging of updates > for them. Unfortunately, sometimes adding X-MFC-WITH is forgotton on follow-up commits, making the commit NOT MFC'ed to stable/* and fire there again. And unfortunately, even though X-MFC-WITH is added, sometimes MFC is missed. > It would be nice if UPDATING reported when a openzfs update > was adding new zpool feature(s) to main and if the loader > was ready for them yet. If not: Later adding an entry for > the loader being ready for the feature(s). +1. > > It's when you enable something on the zpool that you can run into trouble, but that's true independent of upgrade :) > > > > Warner > > Modulo bugs, try test systems first, etc. Of course. > > > > === > Mark Millard > marklmi at yahoo.com > > > -- Tomoaki AOKI