From owner-freebsd-toolchain@FreeBSD.ORG  Tue Mar 31 21:07:22 2015
Return-Path: <owner-freebsd-toolchain@FreeBSD.ORG>
Delivered-To: freebsd-toolchain@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id EFC0DCB9
 for <freebsd-toolchain@freebsd.org>; Tue, 31 Mar 2015 21:07:22 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B329E7D6
 for <freebsd-toolchain@freebsd.org>; Tue, 31 Mar 2015 21:07:22 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t2VL7MIr028256
 for <freebsd-toolchain@freebsd.org>; Tue, 31 Mar 2015 21:07:22 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t2VL7M8s028255;
 Tue, 31 Mar 2015 21:07:22 GMT (envelope-from root)
Date: Tue, 31 Mar 2015 21:07:22 +0000
To: freebsd-toolchain@freebsd.org
From: "dim (Dimitry Andric)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Commented On] D2187: Ensure cross assembler,
 linker and objcopy are used for the build32 stage
Message-ID: <9dad4bfd380916be7ee8cf6166c533e5@localhost.localdomain>
X-Priority: 3
Thread-Topic: D2187: Ensure cross assembler,
 linker and objcopy are used for the build32 stage
X-Herald-Rules: <28>
X-Phabricator-To: <PHID-USER-5dahex5ejhfmjb6awx4r>
X-Phabricator-To: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-To: <PHID-USER-pjrg7uwimqcazthartyl>
X-Phabricator-To: <PHID-USER-2q5asccazp7ohcpzdm6o>
X-Phabricator-Cc: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-Cc: <PHID-MLST-i5ptaleg3lqtvx7cknno>
In-Reply-To: <differential-rev-PHID-DREV-k4xxaczek6fqqbquc4di-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-k4xxaczek6fqqbquc4di-req@FreeBSD.org>
Thread-Index: ZDFjZDBmZDdjODFjNWQ3YTFiYzkzYzkyYjU5IFUbDIo=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-toolchain@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Maintenance of FreeBSD's integrated toolchain
 <freebsd-toolchain.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-toolchain/>
List-Post: <mailto:freebsd-toolchain@freebsd.org>
List-Help: <mailto:freebsd-toolchain-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Mar 2015 21:07:23 -0000

dim added inline comments.

INLINE COMMENTS
  Makefile.inc1:416 These are also unconditionally used in the previous block for WMAKENV, e.g.:
  
  ```
  WMAKEENV+=      CC="${XCC} ${XCFLAGS}" CXX="${XCXX} ${XCFLAGS} ${XCXXFLAGS}" \
                  DEPFLAGS="${DEPFLAGS}" \
                  CPP="${XCPP} ${XCFLAGS}" \
                  AS="${XAS}" AR="${XAR}" LD="${XLD}" NM=${XNM} \
                  OBJDUMP=${XOBJDUMP} OBJCOPY="${XOBJCOPY}" \
                  RANLIB=${XRANLIB} STRINGS=${XSTRINGS} \
                  SIZE="${XSIZE}"
  ```
  
  and just before that, they are unconditionally defined:
  
  ```
  XCOMPILERS=     CC CXX CPP
  .for COMPILER in ${XCOMPILERS}
  .if defined(CROSS_COMPILER_PREFIX)
  X${COMPILER}?=  ${CROSS_COMPILER_PREFIX}${${COMPILER}}
  .else
  X${COMPILER}?=  ${${COMPILER}}
  .endif
  .endfor
  XBINUTILS=      AS AR LD NM OBJCOPY OBJDUMP RANLIB SIZE STRINGS
  .for BINUTIL in ${XBINUTILS}
  .if defined(CROSS_BINUTILS_PREFIX)
  X${BINUTIL}?=   ${CROSS_BINUTILS_PREFIX}${${BINUTIL}}
  .else
  X${BINUTIL}?=   ${${BINUTIL}}
  .endif
  .endfor
  ```
  
  So I think it is unnecessary to check them again.

REVISION DETAIL
  https://reviews.freebsd.org/D2187

To: dim, imp, bapt, rodrigc
Cc: imp, freebsd-toolchain