From owner-svn-src-vendor@FreeBSD.ORG Thu Dec 22 18:40:07 2011 Return-Path: Delivered-To: svn-src-vendor@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 16945106564A; Thu, 22 Dec 2011 18:40:07 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117]) by mx1.freebsd.org (Postfix) with ESMTP id 7C1798FC12; Thu, 22 Dec 2011 18:40:06 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id pBMIcj69092963; Thu, 22 Dec 2011 22:38:45 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id pBMIcjxX092962; Thu, 22 Dec 2011 22:38:45 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Thu, 22 Dec 2011 22:38:45 +0400 From: Gleb Smirnoff To: Dag-Erling Sm??rgrav Message-ID: <20111222183845.GT80057@FreeBSD.org> References: <201112221810.pBMIAFlo028054@svn.freebsd.org> <20111222182219.GS80057@FreeBSD.org> <86bor0sbra.fsf@ds4.des.no> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <86bor0sbra.fsf@ds4.des.no> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, svn-src-vendor@FreeBSD.org Subject: Re: svn commit: r228809 - vendor/openpam/dist/lib X-BeenThere: svn-src-vendor@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the vendor work area tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2011 18:40:07 -0000 On Thu, Dec 22, 2011 at 07:27:05PM +0100, Dag-Erling Sm??rgrav wrote: D> Gleb Smirnoff writes: D> > I haven't yet tested this, but code looks like it is not going to print D> > anything in a case I don't have /usr/local/bin/pam_foo.so, while purpose D> > of the patch is to avoid logging of failure to open D> > /usr/local/bin/pam_foo.so.5. D> > D> > Although openpam_dynamic() will do some logging of errno value, the name D> > of the failed file won't be logged. If I got a lot of modules configured, D> > then I can't figure out which one is ENOENT. D> > D> > IMHO, some no_log flag should be passed down from the try_dlopen() to fix D> > the issue correctly. D> D> Index: openpam_dynamic.c D> =================================================================== D> --- openpam_dynamic.c (revision 509) D> +++ openpam_dynamic.c (working copy) D> @@ -124,7 +124,7 @@ D> dlclose(dlh); D> FREE(module); D> err: D> - openpam_log(PAM_LOG_ERROR, "%m"); D> + openpam_log(PAM_LOG_ERROR, "%s: %m", path); D> return (NULL); D> } If you don't mind, I'd prefer printing vpath here. Looks like in some cases the path may be not absolute, and informing user of open failure is more useful when an exact path where open failed is logged. This would require shifting FREE(vpath) down the function, I hope this isn't a problem. -- Totus tuus, Glebius.