From nobody Sun May 15 06:11:35 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4575C1ACA9C8; Sun, 15 May 2022 06:11:40 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L1Bq019q0z4svL; Sun, 15 May 2022 06:11:40 +0000 (UTC) (envelope-from se@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1652595100; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+q1SimZXsYEknUvdi9/rWRG7fAikLjUY/XJc1ChBKSM=; b=RUbcpfXnHPpxuo7zrY9hvipxebepHrdDKoPXDxUwCcnZikXFuy+rCKzeeQ7/BweZ2owGUS 6KCfbXXy5IggPk5zPzBSTj2HcbB6Z6IEZ8TfvwwhhxWNdGWLPZzmeADQNpjRzoPVEzwZrc Q9od3HNpw9Ehc3qkxoXtIA0Y5unKPvhf+/okAw6sB2y3tChvDC3WQN9Tm2DhmzAjgQqlUu brqajZQI+cgxoMtUc51pdl4uhuQFwIInHeDPZIzrFxFsECfuuMLew8k+QWHlcKjUxC/HXw mtw+pWICqCCnQ/KOrZgUlRlr7wIk4kEFhZLlEBqrgsqqUSrGWbeQss0qdj4Ypg== Received: from [IPV6:2003:cd:5f34:4a00:6d8c:ad45:61e3:4261] (p200300cd5f344a006d8cad4561e34261.dip0.t-ipconnect.de [IPv6:2003:cd:5f34:4a00:6d8c:ad45:61e3:4261]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 62381F245; Sun, 15 May 2022 06:11:39 +0000 (UTC) (envelope-from se@FreeBSD.org) Message-ID: <8b59fa53-1bc1-f5cc-2a97-db42369f1bc3@FreeBSD.org> Date: Sun, 15 May 2022 08:11:35 +0200 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: git: 0810a2380cc0 - main - www/joomla4: Add new port Content-Language: en-US To: Wen Heping References: <202205150142.24F1gTG7047471@gitrepo.freebsd.org> From: Stefan Esser Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org In-Reply-To: <202205150142.24F1gTG7047471@gitrepo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------V9ho0POc1W0nqJG8xW1yLseP" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1652595100; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+q1SimZXsYEknUvdi9/rWRG7fAikLjUY/XJc1ChBKSM=; b=r1Jd9vM0siQTwkc9lZWOPcCqOhLQabuTSoe47eTKiQ700nc0C82pbnzM/oFIZzpaGXNT23 6BNyKAwmvKiNwZ3fLikRyVt9W0OPtIZivVWGRB2Wb0EB8QC2v1LzMNPr5gWYiTXxRF0L9+ oDU2d9eC1bBmdTw9hdGjq7ttrXAxoZaycNdXp1EODv6AE+OGpmTADZWuHb/6cgvoewwQHx iG9fmcMni95MZznPy15qVDjoBmD1zt6wU90g3BE1cmWqnuBAyhGzUtGf2Q713bfGEn5mGp UcjEDBlpnE1W2BtLO1hUDn52UpFzNrOU3QBjGOeWrB/crj+2oivzLe+t8W8wpA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1652595100; a=rsa-sha256; cv=none; b=ESkFYCgIXTDPDeQklC0SC1hmrsZWfE4mqHaCqPMkgzhCX+Doq3mCvlsvEKJhPYiGMUSLkr GyJxEjwJFpYPOfWGe40rRS7oaoeCabEGpXNH6IPg8+K4j7oInkXS+aOy97IyoBesoxRdul +QA4MOx/zwXItNKHwC9DYFTC8wi9Ab/JpLS83L6NpMKL82rxisHBRag9fGJBf3PcsQL2+v O0axCNa/1jN2iRYiDdbiTFWO/ZDrhSKFgRxwHE1NWgFdx1MJ0hl/sFn9UhFSjt6Kv+5p4h tERmwgaG54UbOKQXYfy6Va6kuePUBKImGcTWiIJGD1tZMpPt1+UduqIvxV1EFg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------V9ho0POc1W0nqJG8xW1yLseP Content-Type: multipart/mixed; boundary="------------CIWLAz0Ndj5r02U8SSEOnJ1v"; protected-headers="v1" From: Stefan Esser To: Wen Heping Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Message-ID: <8b59fa53-1bc1-f5cc-2a97-db42369f1bc3@FreeBSD.org> Subject: Re: git: 0810a2380cc0 - main - www/joomla4: Add new port References: <202205150142.24F1gTG7047471@gitrepo.freebsd.org> In-Reply-To: <202205150142.24F1gTG7047471@gitrepo.freebsd.org> --------------CIWLAz0Ndj5r02U8SSEOnJ1v Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 15.05.22 um 03:42 schrieb Wen Heping: > www/joomla3: Add CONFLICTS [...] > +CONFLICTS=3D joomla-4.1.[0-9]* > www/joomla4: Add new port [...] > +CONFLICTS=3D joomla-3.10.[0-9]* Hi, please fix the CONFLICTS entries in both www/joomla3 and www/joomla4. These entries should only contain the PKGBASE of the conflicting package,= whenever possible. See https://docs.freebsd.org/en/books/porters-handbook/book/#conflicts The correct CONFLICTS definitions are: www/joomla3/Makefile: CONFLICTS=3D joomla www/joomla4/Makefile: CONFLICTS=3D joomla3 I have already fixed hundreds of wrong or stale CONFLICTS definitions (and there still are some 2500 in the ports tree, which I want to work on over the next few weeks), and your entries just add to that list. The entry in joomla3 is just wrong, since it will not match the PKGNAME of any joomla4 version. But both will get stale over time without being noticed in the ports system. And BTW: why has the PKGBASE of www/joomla4 been set to just "joomla", not "joomla4"? While version 4 may be supported for some time, there will probably be a joomla5 at some later date and then it would be good to have the names following a scheme that can be continued (i.e., joomla3, joomla4, joomla5) ... Regards, STefan --------------CIWLAz0Ndj5r02U8SSEOnJ1v-- --------------V9ho0POc1W0nqJG8xW1yLseP Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAmKAmZcFAwAAAAAACgkQR+u171r99USq uAgAyaGCwaabC5+Qk0Yijlp35SIW1zjVHHTMtyLyDELAGgTwclV3CSJm8FlRelNz0RjxpPiPcUJw Dp5JuPPvTbH2KlmN/b3biHV1krUFXPDAHWoKF79/g0r/TPrkywbTLIu4SlUCSvtsQmi79Wt2Reyq N0icZKqZFvcauRlFwLMIyRkTt4jDiGTJK74XcPE3Qicr2sK9xQPYBhjOBFEFcLipVFcSlVfNFpej mdopu6n5INL/3fUkOw/HuYkH1waVCgyY3VQf6YeruiSfKNGOEvwiZD3DH1xLLlGmuGqFtxKb88WS GHMMsi6KaOHWjpZiLfkzge3CO4oPDWpWAg8r6WhA+w== =IntL -----END PGP SIGNATURE----- --------------V9ho0POc1W0nqJG8xW1yLseP--