From owner-freebsd-hackers@FreeBSD.ORG Tue Aug 30 18:26:37 2005 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3875216A428 for ; Tue, 30 Aug 2005 18:26:33 +0000 (GMT) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id F288343E44 for ; Tue, 30 Aug 2005 18:26:09 +0000 (GMT) (envelope-from sam@errno.com) Received: from [66.127.85.91] ([66.127.85.91]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.6) with ESMTP id j7UIQ7Bd076427 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 30 Aug 2005 11:26:08 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <4314A65C.4070802@errno.com> Date: Tue, 30 Aug 2005 11:33:00 -0700 From: Sam Leffler User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050327) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Sam Pierson References: <4313A2EC.5070300@errno.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: FreeBSD Hackers Subject: Re: Atheros driver and radiotap reliability X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Aug 2005 18:26:37 -0000 Sam Pierson wrote: > On 8/29/05, Sam Leffler wrote: > >>Sam Pierson wrote: >> >>>I had some correspondence with the ethereal developers and David Young >>>and apparently there is a bug in how ethereal handles the radiotap header. >> >>News to me; the last time I checked it looked correct. > > > I'm not sure. David told me this: > FYI, ethereal's radiotap dissector was broken the last time I checked. :-( > It does not obey the alignment rules for radiotap fields: the radiotap > producer (usually, the kernel) inserts zeroes to ensure natural > alignment of all multi-byte fields. Ethereal does not account for this. > The tcpdump sources get this right. David appears to be talking about how netbsd works. Understand that David does not work on FreeBSD; I'm not even sure he uses it. > > >>The radiotap header includes the rssi returned by the hardware for rx'd >>frames. >> sc->sc_rx_th.wr_antsignal = ds->ds_rxstat.rs_rssi; > > > I get (slightly) different values for the RSSI displayed in ethereal (if it's > correctly being displayed, still looking) than the SS displayed in dB by > tcpdump. Is the SSI displayed by ethereal the sc->sc_rx_th.wr_antsignal > being passed through? tcpdump and ethereal get the same data. If they display it differently given identical data then one is wrong. If you have an example of where things are wrong please present it. > > >>Nothing is recorded for tx frames. You can typically treat it as being >>in .5dBm units relative to the current noise floor. > > > *it*, referring to the rssi value above? "it" = ds->ds_rxstat.rs_rssi which is the value returned by the hardware. Sam