From owner-cvs-src@FreeBSD.ORG Tue Jun 28 18:24:30 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B1EB816A41C; Tue, 28 Jun 2005 18:24:30 +0000 (GMT) (envelope-from sos@FreeBSD.org) Received: from spider.deepcore.dk (cpe.atm2-0-53484.0x50a6c9a6.abnxx9.customer.tele.dk [80.166.201.166]) by mx1.FreeBSD.org (Postfix) with ESMTP id 331D243D1F; Tue, 28 Jun 2005 18:24:30 +0000 (GMT) (envelope-from sos@FreeBSD.org) Received: from [194.192.25.136] (mac.deepcore.dk [194.192.25.136]) by spider.deepcore.dk (8.13.3/8.13.3) with ESMTP id j5SIIsYJ045106; Tue, 28 Jun 2005 20:18:54 +0200 (CEST) (envelope-from sos@FreeBSD.org) In-Reply-To: <200506281310.50238.jhb@FreeBSD.org> References: <200506280906.j5S96qIi053675@repoman.freebsd.org> <200506280951.10203.jhb@FreeBSD.org> <200506281310.50238.jhb@FreeBSD.org> Mime-Version: 1.0 (Apple Message framework v730) Content-Type: text/plain; charset=ISO-8859-1; delsp=yes; format=flowed Message-Id: <8EFCED13-E340-4C7D-A13B-3A5B01C4241E@FreeBSD.org> Content-Transfer-Encoding: quoted-printable From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= Date: Tue, 28 Jun 2005 20:24:27 +0200 To: John Baldwin X-Mailer: Apple Mail (2.730) X-mail-scanned: by DeepCore Virus & Spam killer v1.12 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ata ata-queue.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2005 18:24:30 -0000 On 28/06/2005, at 19:10, John Baldwin wrote: > On Tuesday 28 June 2005 11:30 am, S=F8ren Schmidt wrote: > >> On 28/06/2005, at 15:51, John Baldwin wrote: >> >>> On Tuesday 28 June 2005 05:06 am, SXren Schmidt wrote: >>> >>>> sos 2005-06-28 09:06:52 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> sys/dev/ata ata-queue.c >>>> Log: >>>> Zero donecount on auto request sense. >>>> >>>> PR: 81450 >>>> Approved by: re@ (scottl) >>>> >>> >>> Are you going to commit this to 5.x now as well? FWIW, the patch >>> in question >>> was straight from the bug report as well. >>> >> >> Well, I thought that the plan was to have 6.0 be the solution to 5.x >> problems ;) >> >> Anyhow if/when I'll commit anything to 5.x, it will be the ATA driver >> from 6.0/current. >> The problem being that the ABI for atacontrol etc has changed so it >> kindof breaks the charter of -stable IMHO. >> Other than that I have the bits sitting here on my lone -stable box >> just waiting for a push on the big red commit key :) >> . >> - S=F8ren >> > > Well is it ok if I merge just this change to 5.x then? As I've stated earlier I don't support what's been put into 5.x to =20 "fix" bugs. ATA mkIII is the fix for the 5.x problems/bugs from this end, so you =20 can do exactly what you want on the ATA code in 5.x as I don't really =20= care :) - S=F8ren