From owner-p4-projects@FreeBSD.ORG  Sat Aug  2 19:24:10 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id F41791065673; Sat,  2 Aug 2008 19:24:09 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B6D92106564A;
	Sat,  2 Aug 2008 19:24:09 +0000 (UTC)
	(envelope-from kientzle@freebsd.org)
Received: from kientzle.com (kientzle.com [66.166.149.50])
	by mx1.freebsd.org (Postfix) with ESMTP id 7868D8FC1B;
	Sat,  2 Aug 2008 19:24:09 +0000 (UTC)
	(envelope-from kientzle@freebsd.org)
Received: from [10.0.0.129] (p54.kientzle.com [66.166.149.54])
	by kientzle.com (8.12.9/8.12.9) with ESMTP id m72JO9tv015582;
	Sat, 2 Aug 2008 12:24:09 -0700 (PDT)
	(envelope-from kientzle@freebsd.org)
Message-ID: <4894B486.8000102@freebsd.org>
Date: Sat, 02 Aug 2008 12:24:54 -0700
From: Tim Kientzle <kientzle@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060422
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Anselm Strauss <strauss@freebsd.org>
References: <200807312046.m6VKkKc1042376@repoman.freebsd.org>
In-Reply-To: <200807312046.m6VKkKc1042376@repoman.freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 146346 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Aug 2008 19:24:10 -0000

Anselm Strauss wrote:
> http://perforce.freebsd.org/chv.cgi?CH=146346

> -	/* assertEqualInt(i4(p + 16), XXXX); */ /* CRC-32 */
> +	assertEqualInt(i4(p + 16), crc32(0, &data, sizeof(data))); /* CRC-32 */

This is a nice, straightforward way to test this functionality.
Good work.

It would be nice to change the test code to write the data
as two operations:  write the first 5 bytes, maybe, then
write the rest.  That would test the CRC code a little more
thoroughly.

Tim