From owner-cvs-all@FreeBSD.ORG  Thu Nov  1 12:33:52 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5CD7116A419;
	Thu,  1 Nov 2007 12:33:52 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from fallbackmx01.syd.optusnet.com.au
	(fallbackmx01.syd.optusnet.com.au [211.29.132.93])
	by mx1.freebsd.org (Postfix) with ESMTP id 659E913C4BC;
	Thu,  1 Nov 2007 12:33:49 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail34.syd.optusnet.com.au (mail34.syd.optusnet.com.au
	[211.29.133.218])
	by fallbackmx01.syd.optusnet.com.au (8.12.11.20060308/8.12.11) with
	ESMTP id l9VGtNg1012380; Thu, 1 Nov 2007 03:55:23 +1100
Received: from c211-30-219-213.carlnfd3.nsw.optusnet.com.au
	(c211-30-219-213.carlnfd3.nsw.optusnet.com.au [211.30.219.213])
	by mail34.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	l9VGs3hU022786
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 1 Nov 2007 03:54:04 +1100
Date: Thu, 1 Nov 2007 03:54:17 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@delplex.bde.org
To: Bruce Evans <brde@optusnet.com.au>
In-Reply-To: <20071031205412.U3526@delplex.bde.org>
Message-ID: <20071101034838.H4676@delplex.bde.org>
References: <200710150951.l9F9pUm7026506@repoman.freebsd.org>
	<4720B30F.4040903@samsco.org> <20071025151707.GA11398@nagual.pp.ru>
	<4720E0AF.1010004@samsco.org> <4720E904.2090704@delphij.net>
	<20071031205412.U3526@delplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: Scott Long <scottl@samsco.org>, src-committers@FreeBSD.org, d@delphij.net,
	Andrey Chernov <ache@nagual.pp.ru>, cvs-all@FreeBSD.org,
	cvs-src@FreeBSD.org
Subject: Re: cvs commit: src/lib/libc/locale utf8.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Nov 2007 12:33:52 -0000

On Wed, 31 Oct 2007, Bruce Evans wrote:

> __mb_sb_limit is extern int, so the ABI breakage was obvious.  If it
> had been a compile-time constant with the usual ${CFLAGS} but not a
> constant with -O0, of if the constant depended on ${CFLAGS} or changed
> with __FreeBSD_version, then the problem would have been less obvious.
>
> Now the limit is spelled 128, so it really is constant and won't cause
> problems unless the constant changes.
>
> _ctype.h still declares __mb_sb_limit but now doesn't use it.
> ...

Oops, I didn't realize at first that you only changed it to 128 in one
place.  Changing it in only one place (which affects little more than
isdigit()) hardly seems worth it.  It leaves the ABI problem, and the
optimization is tiny.

Bruce