From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Dec 3 16:30:13 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 44D481065670 for ; Sat, 3 Dec 2011 16:30:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 2997C8FC12 for ; Sat, 3 Dec 2011 16:30:13 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pB3GUCoE037608 for ; Sat, 3 Dec 2011 16:30:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pB3GUCWG037604; Sat, 3 Dec 2011 16:30:12 GMT (envelope-from gnats) Date: Sat, 3 Dec 2011 16:30:12 GMT Message-Id: <201112031630.pB3GUCWG037604@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Kalten Cc: Subject: Re: ports/162996: games/ioquake3-devel: update s2064->s2202 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Kalten List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Dec 2011 16:30:13 -0000 The following reply was made to PR ports/162996; it has been noted by GNATS. From: Kalten To: bug-followup@freebsd.org, Dominic Fandrey Cc: Subject: Re: ports/162996: games/ioquake3-devel: update s2064->s2202 Date: Sat, 03 Dec 2011 17:11:28 +0100 Hello! > ports/162301 [=E2=80=A6] I won't accept any patches until that has been > submitted. Very well. > [=E2=80=A6significant changes to the freebsd-patchset=E2=80=A6incompatibl= e=E2=80=A6] Very likely than. I should have searched for open PRs about `ioquake3-devel'---I am sorry. Too much of a hurry (as already mentioned in my first post) :-( > There's no need to bump PORTREVISION, because SVNVERSION is part of > the DISTVERSION. Ah! Sorry. I did not pay enough attention :-( > Also, if you update ioq3-devel you also need to update openarena and > iourbanterror. Oh. I did not think of such things either---slave ports... Is there a better way than a grep for "\.include .*/ioquake3/Makefile" and "\.include .*/ioquake3-devel/Makefile" in Makefiles? > Some advice under the assumption that you'll maintain ports in the > future: Run "port test" or "port test -L", so you're certain you > didn't forget to update the plist. You do mean ports-mgmt/porttools/, am I right? Veeery nice tool! Good lord---there is much "port test" (using portlint) does not like about the original games/ioquake3/ and games/ioquake3-devel/ ;-) Maybe most interesting of all at -devel ``[=E2=80=A6] but this port is not configured as a slave port''. I suppose the fact that there is no Warning/Error in the section `=3D=3D=3D> Extra files and directories check' means, that nothing has not been deinstalled that had been installed? Well: that is not true for my dirty version---I get it. It has been installed directly into /usr/... not into /tmp/io... as my copy command using ${LOCALBASE} obviously did not use ${PREFIX} (/usr/ports/Mk/bsd.port.mk does not use ${PREFIX} in it. I could not use ${DATADIR} as it defaults to ${PREFIX}/share/${PORTNAME}. ${PREFIX}/share/quake3 would have been better, right? Or to find the spot in the source and patch it to use ${DATADIR}, right?) > Also it's a good idea to compile your changes into a single patch, so > you don't burden committers with having to apply a bunch of patches, > especially from different locations. Well: OK. So one patch to be applied from /usr/ports/games/ and tell so in the description would be preferable? > As far as the master->slave port thing goes you dabbled into one > of the more complex arrangements. I'd like to litter the thing with > comments, but that's not usual for the ports and would probably be > frowned upon (the tree is supposed to stay reasonable small). I see. Maybe some good descriptions in the Porter's Handbook[1]---I think `5.8 MASTERDIR'[2] is the right section? (some comment like `master-/slave ports' in the heading would not hurt as `portlint' and by that `port test' mentions `[=E2=80=A6] not configured as a slave port'). Good luck with your updates! Kalten [1] http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/ [2] http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makef= ile-masterdir.html --=20