From owner-freebsd-arm@FreeBSD.ORG Fri Jan 23 21:54:56 2015 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 393BB45F for ; Fri, 23 Jan 2015 21:54:56 +0000 (UTC) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "gold.funkthat.com", Issuer "gold.funkthat.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 9B8D898A for ; Fri, 23 Jan 2015 21:54:55 +0000 (UTC) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.14.5/8.14.5) with ESMTP id t0NLaJCU010435 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 23 Jan 2015 13:36:19 -0800 (PST) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.14.5/8.14.5/Submit) id t0NLaJdr010434; Fri, 23 Jan 2015 13:36:19 -0800 (PST) (envelope-from jmg) Date: Fri, 23 Jan 2015 13:36:19 -0800 From: John-Mark Gurney To: Warner Losh Subject: Re: mount_smbfs Message-ID: <20150123213619.GP1949@funkthat.com> References: <54B9DCD1.3040306@foxvalley.net> <4759EAA0-D4AA-4923-9350-B7E753819169@me.com> <6E32991C3BD8465DB8DB0E65DFDA47AA@ad.peach.ne.jp> <20150123195403.GO1949@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD 9.1-PRERELEASE amd64 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (gold.funkthat.com [127.0.0.1]); Fri, 23 Jan 2015 13:36:19 -0800 (PST) Cc: freebsd-arm , Rui Paulo X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jan 2015 21:54:56 -0000 Warner Losh wrote this message on Fri, Jan 23, 2015 at 13:21 -0800: > > > On Jan 23, 2015, at 11:54 AM, John-Mark Gurney wrote: > > > > Daisuke Aoyama wrote this message on Sat, Jan 24, 2015 at 03:07 +0900: > >> Quick hack patch is attached. > > > > Please use {l,b}e16dec, or if the code is suppose to be native endian, > > make it dependant on __NO_STRICT_ALIGNMENT and add the proper endian > > swap, not __arm__ as there are other arches that require the same fix... > > If there???s just a couple of places that need this, don???t bother making them dependent > on __NO_STRICT_ALIGNMENT. That clutters things up a bit too much. Given the 3 > or 4 places this is used, and the relative infrequency of the calls, just doing a memcpy > unconditionally is always correct and reduces the risk of one branch of the #if being > changed w/o the other. Since it is already using NBENCODE(), I think that using > {l,b}e16enc (not dec) would be a larger code churn. Clearly neither of us looked at the code closely... NBENCODE should be rewritten to take a pointer and use le16enc... Then memsetw should just call NBENCODE internally as it goes... Also, as this is in contrib, the patch should be submitted upstream... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."