From nobody Thu Mar 2 04:42:49 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PRz4J31c9z3vpXB; Thu, 2 Mar 2023 04:42:56 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PRz4J2C0Tz4J2K; Thu, 2 Mar 2023 04:42:56 +0000 (UTC) (envelope-from kevans@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677732176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q1EjtoDpm104tcKPMPhKDywF3QPprz4z1FjC3KOHCmE=; b=W10eprXx5mrutdL03eRtzpSCnhzLT+ZjDNwFyKbUE0YvoevXP2svY+kFSTgYfCINCSdcLu zy4EsazCRiPWga5YiR3kiaSMPdMQKjGtZi18olzMRsYIuXxsx+Y2LlX5aZWExXjmOZcKkt 0rrLxk//iFIqcCRzSmTZRlXPyAJi321mLyp20IZgnE8pBsdtBKQjv3z9jd0cgsLQlEly16 WSP2c+VFOqg2R6z10vcRrmpBAosnU0V+3aPSMnPrI9lDtRfd1pyljtlnmrewe4mNNQ5Arr bL/lbzM82bEw5u6HVpiUhiBHVXNTL4aI1/KFUkOOKijVM7Bh8fP0nORRKw8iLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677732176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q1EjtoDpm104tcKPMPhKDywF3QPprz4z1FjC3KOHCmE=; b=fCAcip3aja3/6VWOsrotBhcNzEt7lffuwfmsfSYZiaxhe82Y7C9A9rMhxw3121di6m1d6D QzWOn7L0ATyWr7iKAqrjxtI/C+Rw/CIi90l9Pu9sWH3777JNOEVqeXQt/0m/EL/opyKgtx Bx3dDnj4WNXau+zZYimP2/GgjHkrKggvHxcrDH3q36cocY/yVhqM5Q7TnzybVRwSs8GGZr qQb8FfJPbmhQpjQ+STGVdn58cDoJrOLHdmS3DcK1VR2D7H45syotno1YB3W0/Yc8LULUbp cTjFAdT9czu7SOP7s0+aqoshrk2YjncQVrtM3IeyH0bTtW0OMjtFTDsytokMMA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1677732176; a=rsa-sha256; cv=none; b=eQpEZIW4/fXfMDvSbxLseZYHxvIryCKqw7S2MQg/e5NYHNTEq+VTZCQH3C0f7a2JGBILIa rMPozKX/mWx/X+6iwQfMrddNw/HXqCM1Zx4ZAnNzhUH7jCjkJlv8zJmVa1gZuhRY7Je2q1 kfU0Pw04Sn/FKGX3yQUYNjfxECDfWR6rqI9RP4K+rgpzzxum0sXxKRVLg8O+FzQMYfg4Cp +dfcLY3oXJ57A3bfyCcpgJJCTRGGtZtFNtJwneHurGtP3ZgogfRlTAuw51T4I5VRkZ3MET G69hDJoERoBJVSaJMt8Tv61fZN6QGuL75bPQArGrxGcCelAp9S1WjIjXeTp8wA== Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PRz4J1Fw8zL6Y; Thu, 2 Mar 2023 04:42:56 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qk1-f178.google.com with SMTP id q2so5597387qki.3; Wed, 01 Mar 2023 20:42:56 -0800 (PST) X-Gm-Message-State: AO0yUKV4sVNcSK81QeCM3g1FNwIWdmvwLMM3ECJzVvrcjub3ktSyjy0n 3MzNacuHJEUTW4nI8H+pKqDM/Ko7cDeKU2IPyBg= X-Google-Smtp-Source: AK7set+FtP3dwxMr52D1NC9oVjqxPVlqxJUIxq7hazu6LAJpWPllp41Z6gP9bW5Qa8rpCINVPCyytA7QMtmacrdFP1M= X-Received: by 2002:a05:620a:1327:b0:742:7fb5:f505 with SMTP id p7-20020a05620a132700b007427fb5f505mr2207028qkj.14.1677732175490; Wed, 01 Mar 2023 20:42:55 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202303020300.32230wHb032429@gitrepo.freebsd.org> In-Reply-To: From: Kyle Evans Date: Wed, 1 Mar 2023 22:42:49 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 6b4ef4b16a69 - main - daemon: use braces with 'if' consistently To: Alexey Dokuchaev Cc: Kyle Evans , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-ThisMailContainsUnwantedMimeParts: N On Wed, Mar 1, 2023 at 10:28=E2=80=AFPM Alexey Dokuchaev wrote: > > On Thu, Mar 02, 2023 at 03:00:58AM +0000, Kyle Evans wrote: > > commit 6b4ef4b16a6930d91d0d99c4ceb75cd43a7526c1 > > > > daemon: use braces with 'if' consistently > > [...] > > ... > > diff --git a/usr.sbin/daemon/daemon.c b/usr.sbin/daemon/daemon.c > > index edcdf3141fcc..f9c1f73e193c 100644 > > --- a/usr.sbin/daemon/daemon.c > > +++ b/usr.sbin/daemon/daemon.c > > @@ -173,14 +173,16 @@ main(int argc, char *argv[]) > > break; > > case 'l': > > logfac =3D get_log_mapping(optarg, facilitynames)= ; > > - if (logfac =3D=3D -1) > > + if (logfac =3D=3D -1) { > > errx(5, "unrecognized syslog facility"); > > + } > > Not only that I don't quite understand how does this commit really > improve anything, but looks like it's badly formatted as well. > A-ha, thought I had caught all of the style issues but it appears not. Thanks, Kyle Evans