From owner-svn-src-all@freebsd.org  Tue Oct 20 20:56:26 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 676CCA0AE42;
 Tue, 20 Oct 2015 20:56:26 +0000 (UTC)
 (envelope-from cse.cem@gmail.com)
Received: from mail-yk0-f177.google.com (mail-yk0-f177.google.com
 [209.85.160.177])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 2F0F81FEC;
 Tue, 20 Oct 2015 20:56:25 +0000 (UTC)
 (envelope-from cse.cem@gmail.com)
Received: by ykaz22 with SMTP id z22so29722862yka.2;
 Tue, 20 Oct 2015 13:56:18 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=mime-version:reply-to:in-reply-to:references:date:message-id
 :subject:from:to:cc:content-type;
 bh=Q1wdIKoPwHElG90DnuWa7eF/L5CPY/6w/gYJDv8ZDdU=;
 b=fUQbyz+VuKMD5beL05640kPI1AhyuLQAPl1SzHpJnG/NjA1ObfKPrQhxw8mJbhws21
 iNHTOTRIUhg9DVZEvvfHKj2hMY7UgSfpmR4ym6M70yEPNOtnq8DpnRC+G33FG7tmTkhe
 XJ5OhX4ZhZfxzBbb1PA3TvRHw/7ffO/phl/uI7ZV7R6IR9YF6OAcCJfxT9w/olWnUhVS
 xrfJmz8/G+On6YxZe8fJchVplXWF1vq7IKh849mPudDu/tKsSEHLWiOAKwOyyowgql51
 l0c/G19ZSAkT/W0k+756XS8cwr5If55P1Hx4+l3N+5HTtYROCF2V3GXlzaGLd9ndyyZx
 837w==
X-Received: by 10.129.147.198 with SMTP id k189mr3831009ywg.282.1445374181034; 
 Tue, 20 Oct 2015 13:49:41 -0700 (PDT)
Received: from mail-yk0-f171.google.com (mail-yk0-f171.google.com.
 [209.85.160.171])
 by smtp.gmail.com with ESMTPSA id f133sm3064216ywa.27.2015.10.20.13.49.40
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 20 Oct 2015 13:49:40 -0700 (PDT)
Received: by ykba4 with SMTP id a4so23405741ykb.3;
 Tue, 20 Oct 2015 13:49:40 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.129.31.195 with SMTP id f186mr835185ywf.204.1445374180518;
 Tue, 20 Oct 2015 13:49:40 -0700 (PDT)
Reply-To: cem@FreeBSD.org
Received: by 10.37.203.75 with HTTP; Tue, 20 Oct 2015 13:49:40 -0700 (PDT)
In-Reply-To: <201510202037.t9KKb0sk064214@repo.freebsd.org>
References: <201510202037.t9KKb0sk064214@repo.freebsd.org>
Date: Tue, 20 Oct 2015 13:49:40 -0700
Message-ID: <CAG6CVpU102N8OGvVe7j=wygx3DaLEzmBoDZw8WE1vbTViSqoWQ@mail.gmail.com>
Subject: Re: svn commit: r289663 - head/share/mk
From: Conrad Meyer <cem@FreeBSD.org>
To: Bryan Drewery <bdrewery@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Oct 2015 20:56:26 -0000

On Tue, Oct 20, 2015 at 1:37 PM, Bryan Drewery <bdrewery@freebsd.org> wrote:
> Author: bdrewery
> Date: Tue Oct 20 20:37:00 2015
> New Revision: 289663
> URL: https://svnweb.freebsd.org/changeset/base/289663
>
> Log:

I think this should read:

>   Improve safety of caching from r289659 by only importing of none of the

... by only importing *if* none of the ...

>   variables are already set.  This should cover odd cases such as the
>   COMPILER_TYPE override in lib/csu/powerpc64.

Best,
Conrad