From owner-svn-src-all@FreeBSD.ORG  Sat Nov 29 17:08:05 2008
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 05BB01065677;
	Sat, 29 Nov 2008 17:08:05 +0000 (UTC)
	(envelope-from ganbold@micom.mng.net)
Received: from publicd.ub.mng.net (publicd.ub.mng.net [202.179.0.88])
	by mx1.freebsd.org (Postfix) with ESMTP id B32458FC23;
	Sat, 29 Nov 2008 17:08:04 +0000 (UTC)
	(envelope-from ganbold@micom.mng.net)
Received: from [202.179.21.130] (helo=devil.micom.mng.net)
	by publicd.ub.mng.net with esmtpa (Exim 4.69 (FreeBSD))
	(envelope-from <ganbold@micom.mng.net>)
	id 1L6TIY-000NVi-GP; Sun, 30 Nov 2008 01:08:02 +0800
Message-ID: <493176F1.5070805@micom.mng.net>
Date: Sun, 30 Nov 2008 01:08:01 +0800
From: Ganbold <ganbold@micom.mng.net>
User-Agent: Thunderbird 2.0.0.17 (X11/20081020)
MIME-Version: 1.0
To: Rui Paulo <rpaulo@FreeBSD.org>
References: <200811291420.mATEKa6t053437@svn.freebsd.org>
In-Reply-To: <200811291420.mATEKa6t053437@svn.freebsd.org>
X-Enigmail-Version: 0.95.7
OpenPGP: id=78F6425E
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r185433 - head/sys/dev/asmc
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Nov 2008 17:08:05 -0000

Rui Paulo wrote:
> Author: rpaulo
> Date: Sat Nov 29 14:20:36 2008
> New Revision: 185433
> URL: http://svn.freebsd.org/changeset/base/185433
>
> Log:
>   Check for non-existing model DMI string.
>   
>   Submitted by:	ganbold
>   Found with:	Coverity Prevent(tm)
>   CID:         	2434
>   MFC after:	1 week
>
> Modified:
>   head/sys/dev/asmc/asmc.c
>
> Modified: head/sys/dev/asmc/asmc.c
> ==============================================================================
> --- head/sys/dev/asmc/asmc.c	Sat Nov 29 13:34:59 2008	(r185432)
> +++ head/sys/dev/asmc/asmc.c	Sat Nov 29 14:20:36 2008	(r185433)
> @@ -254,6 +254,9 @@ asmc_match(device_t dev)
>  	char *model;
>  
>  	model = getenv("smbios.system.product");
> +	if (model == NULL)
> +		return (NULL);
> +
>  	for (i = 0; asmc_models[i].smc_model; i++) {
>  		if (!strncmp(model, asmc_models[i].smc_model, strlen(model))) {
>  			freeenv(model);
> _______________________________________________
> svn-src-all@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/svn-src-all
> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
>
>
>
>   
Thank you.

Ganbold

-- 
When a girl can read the handwriting on the wall, she may be in the
wrong rest room.