Date: Wed, 24 Oct 2018 15:45:39 +0200 From: Luca Pizzamiglio <pizzamig@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r482294 - head/devel/sccache Message-ID: <CAB88xy_2rP%2Bn5wtrxYiJqhxSng3MdaYaeB%2BnYTmx=45C=_GJOA@mail.gmail.com> In-Reply-To: <20181024083541.4q726xezswwqe2xo@atuin.in.mat.cc> References: <201810171315.w9HDFrgI039873@repo.freebsd.org> <20181024083541.4q726xezswwqe2xo@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
I tend to disagree. Before this change, I've received pkg_fallout emails. Probably I misused the work "dependency". It's a crate (openssl.0.9.24) that fails to build because of OpenSSL 1.1.1. I've already reported it upstream, but the best way to solve it is not trivial (https://github.com/mozilla/sccache/issues/311) Rust dependencies (crates) are statically linked in the final executable, so if a dependency crate fails to build, the whole application failed to build. Crates are not shared library, they are shared API statically linked to the final executable. security/openssl as runtime dependency will cause conflict with the base one (ld-elf.so.1: /usr/local/lib/libcrypto.so.9: version OPENSSL_1_1_0 required by /usr/local/lib/libpkg.so.4 not defined, for instance) I could use security/openssl as build dependency and let the openssl crate to statically link to it, but I don't like this approach, because at every security/openssl fix, I have to bump portrevision of sccache. Best regards pizzamig@ On Wed, Oct 24, 2018 at 3:23 PM Mathieu Arnold <mat@freebsd.org> wrote: > On Wed, Oct 17, 2018 at 01:15:53PM +0000, Luca Pizzamiglio wrote: > > Author: pizzamig > > Date: Wed Oct 17 13:15:53 2018 > > New Revision: 482294 > > URL: https://svnweb.freebsd.org/changeset/ports/482294 > > > > Log: > > devel/sccache: ignore on CURRENT if openssl 1.1.1 based > > > > The current chain of dependencies doens't support openssl 1.1.1 > > This change is bobus. First, I think it works just fine on current if > using security/openssl. Also, this port is not incompatible with > openssl 1.1.1, only one of its dependency is, so this is not needed. > > > Modified: > > head/devel/sccache/Makefile > > > > Modified: head/devel/sccache/Makefile > > > ============================================================================== > > --- head/devel/sccache/Makefile Wed Oct 17 13:14:17 2018 > (r482293) > > +++ head/devel/sccache/Makefile Wed Oct 17 13:15:53 2018 > (r482294) > > @@ -282,10 +282,16 @@ CARGO_CRATES= adler32-1.0.3 \ > > xattr-0.2.2 \ > > zip-0.4.2 > > > > +.include <bsd.port.pre.mk> > > + > > +.if ${OPSYS} == FreeBSD && ${OSVERSION} > 1200084 > > +IGNORE= openssl 1.1.1 is incompatible with the reqwest 0.8.8 > dependencies > > +.endif > > + > > do-install-DOCS-on: > > @${MKDIR} ${STAGEDIR}${DOCSDIR} > > ${INSTALL_DATA} ${WRKSRC}/README.md ${STAGEDIR}${DOCSDIR} > > > > post-install: > > ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/sccache > > -.include <bsd.port.mk> > > +.include <bsd.port.post.mk> > > > > > > -- > Mathieu Arnold >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAB88xy_2rP%2Bn5wtrxYiJqhxSng3MdaYaeB%2BnYTmx=45C=_GJOA>