From owner-freebsd-arch Wed Feb 27 15: 4:51 2002 Delivered-To: freebsd-arch@freebsd.org Received: from avocet.prod.itd.earthlink.net (avocet.mail.pas.earthlink.net [207.217.120.50]) by hub.freebsd.org (Postfix) with ESMTP id C724A37B437 for ; Wed, 27 Feb 2002 15:03:49 -0800 (PST) Received: from pool0052.cvx40-bradley.dialup.earthlink.net ([216.244.42.52] helo=mindspring.com) by avocet.prod.itd.earthlink.net with esmtp (Exim 3.33 #1) id 16gD6q-0000pp-00; Wed, 27 Feb 2002 15:03:40 -0800 Message-ID: <3C7D6586.558B8EE1@mindspring.com> Date: Wed, 27 Feb 2002 15:02:30 -0800 From: Terry Lambert X-Mailer: Mozilla 4.7 [en]C-CCK-MCD {Sony} (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Bosko Milekic Cc: Matthew Dillon , Alfred Perlstein , Julian Elischer , Jeff Roberson , arch@FreeBSD.ORG Subject: Re: Slab allocator References: <200202271926.g1RJQCm29905@apollo.backplane.com> <20020227194256.GR80761@elvis.mu.org> <200202271955.g1RJtAj30178@apollo.backplane.com> <20020227151722.B42681@unixdaemons.com> <3C7D4958.D1B8CD3D@mindspring.com> <20020227171945.B46831@unixdaemons.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Bosko Milekic wrote: > OK, since you obviously know what you're talking about, how about you > sit down and produce some patches for Jeff? I think he would appreciate > it very much, instead of the generalizations and "you should not do > this, but do X" abstractions. Before you get up in arms... in case this wasn't clear... I think that his code is importable without any patches. I was pointing out how the complaints people have can be addressed without altering the theme or the majority of the code itself. I was not suggesting that the changes must be made before import. The comments on not renaming the files, and the prefix on the name are salient, as are the statistics comments (keep appropriate statistics, rather than trying to emulate previously appropriate statistics). I would like to see him address the issues he feels need to be addressed, but since the performance is not worse with the code, all of that can be handled later, after an import. It's certain that the current allocation code can't SMP scale the way Jeff's code can and it's a step in the right direction. Now is the time to get things into -current, so that they can be stabilized (if necessary) and improved (I think several people, myself included, believe the code can be improved, but it doesn't have to be before it can go in). Kirk likes the code; what else is required before simply importing it, and making the vm_zone code optional so that the rest can be converted? -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message