From owner-svn-src-head@freebsd.org Thu May 10 13:57:35 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 25622FCA5AE; Thu, 10 May 2018 13:57:35 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-it0-x22f.google.com (mail-it0-x22f.google.com [IPv6:2607:f8b0:4001:c0b::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A867385494; Thu, 10 May 2018 13:57:34 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-it0-x22f.google.com with SMTP id y189-v6so3196446itb.2; Thu, 10 May 2018 06:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=q8U75OimIoQntFCqVQGIRM1JyLx+5mwnPldgpXsGIUA=; b=qCjISwd9w0f/esnUz/MDvHpjCdjTs20toSNP4TCKqJq4LTyqpPCOZqjIPal0j7y0RZ D+bkYEQejMDQ/hcNOJnGv9r8sagFk75F7yf6A4j9fw5oizH5zrBg38MG77+gg9IT2Rwe 5ppfUDYTb36nTuVl2+YD1qlXk1RB0b9Iahc6qz4exFu1cO/u3dOKxH7LomqzVPmJfkSK JjRaSqbHZeyDJWwcp3M0vZvebTztdUu5tgOV06wtiEtmfaY6Bx6ctQsisEQ7+/OPIiMN bDERGnWIjswxDwAVSGJhRvkfa5ZoJklQx0K9JpjLLX/7bOhdzRQKdeWloRiesrTZg47e VjIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=q8U75OimIoQntFCqVQGIRM1JyLx+5mwnPldgpXsGIUA=; b=DmH6FnvgT0egVkjyvu3YzU1V+C4hCeILMI9f8z8TlLFBLnvxec6sBgSlgeYpqspd7O Iz3cwc2QLS17kX167i8WT/tuuLdQ+hi8hbmTEYi5l/vj57U+Ero1P1QVA5gZ5Zrq54oN 9LddYezFiCI89/ykpPeuDdpDVR+hdr9+za/jlLIlp1hJgaS6Wk5DygIMIuRb6s3H+QoM Ysm29j88Te1Zxz059SkeJ0HTcOoYoxsN3kV+moLVxMiJxWtoSbQKZ+0qQCo9whaJ50cU 9breP5qCnrMxaHlw9pBkIYitTCNlGIEbb6EuLwhrHEPamBoGK6HoCSlF9Jqq7GV/Bgjl 3WbQ== X-Gm-Message-State: ALKqPwdF0L7iv/M1QFTuE+ZNg6xyDXpVKHWBGLuSLQzjQ56cwd8H+tkM N8iYAeRpjMNPDxm1n4srgAZPy4C/NRhfcnQnDc680w== X-Google-Smtp-Source: AB8JxZr6164v5+wyKpa9I7SAbDQG4sKUQ/Pftav6erL7ucl7ISKWM2H/Pig7BVnBtsyuZGPXaDgmdYkuMokAJWXPlKc= X-Received: by 2002:a24:2fce:: with SMTP id j197-v6mr1732761itj.52.1525960653684; Thu, 10 May 2018 06:57:33 -0700 (PDT) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.130.167 with HTTP; Thu, 10 May 2018 06:57:13 -0700 (PDT) In-Reply-To: References: <201805101136.w4ABaG7G034274@repo.freebsd.org> From: Ed Maste Date: Thu, 10 May 2018 09:57:13 -0400 X-Google-Sender-Auth: biVd3rgpePq7QvMtFYeOyVGfq2c Message-ID: Subject: Re: svn commit: r333457 - head/sys/kern To: Andrew Gallatin Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 13:57:35 -0000 On 10 May 2018 at 09:18, Andrew Gallatin wrote: > On 05/10/18 07:36, Ed Maste wrote: >> >> Author: emaste >> Date: Thu May 10 11:36:16 2018 >> New Revision: 333457 >> URL: ... >> >> Log: >> ANSIfy sys_generic.c > > This breaks the kernel build: > > /usr/src/sys/kern/sys_generic.c:522:1: error: conflicting types for > 'kern_pwritev' > kern_pwritev(struct thread *td, struct uio *auio, int fd, off_t offset) > ^ > /usr/src/sys/sys/syscallsubr.h:212:5: note: previous declaration is here > int kern_pwritev(struct thread *td, int fd, struct uio *auio, off_t > offset); > ^ > 1 error generated. > *** [sys_generic.o] Error code 1 Sorry about the breakage, and thanks for reporting and fixing. I merged from FreeBSD to my WIP tree, and was reminded that I had this change because r333425 included an adjacent change. When making the change in svn I accidentally reintroduced the misordering.