From owner-freebsd-wireless@FreeBSD.ORG  Fri Sep 28 16:22:44 2012
Return-Path: <owner-freebsd-wireless@FreeBSD.ORG>
Delivered-To: freebsd-wireless@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 06A90106564A
	for <freebsd-wireless@freebsd.org>;
	Fri, 28 Sep 2012 16:22:44 +0000 (UTC)
	(envelope-from adrian.chadd@gmail.com)
Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com
	[209.85.220.54])
	by mx1.freebsd.org (Postfix) with ESMTP id CDC978FC08
	for <freebsd-wireless@freebsd.org>;
	Fri, 28 Sep 2012 16:22:43 +0000 (UTC)
Received: by padbi1 with SMTP id bi1so2728213pad.13
	for <freebsd-wireless@freebsd.org>;
	Fri, 28 Sep 2012 09:22:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	bh=mFPWyE/mpNPlcIr9QWhTsl4W5MInzN+YTnNiTnaKyig=;
	b=ao8ScbNOwr4UM2vFUYA4rORkAPkMJByvLVnzdIbzOOAxSnYFafttW3soK+oHvNc+cW
	EiVxdYQR6JSdqnqHmkbImLnwY+/l5kKGGBzUrUdhIQIc80ds2zyi/VVBpla2uekunsjj
	zWeLtPJE51pV6964sbbPwheX5IOTUfpXYbFC/lw2zmPrKEa2NxYm8yqA4a45G2ogFupP
	TDIl+HO/fMi3sYTaBJkaiwUYElFAzoP1x6vOxY0821Rfz1d+XXpNIbg+CfSi3xEfgkBG
	zXI1kVrltJvNM2pvT0qzbGuk3TyNkCrJlCUxlPAuyslklxS1FHe7oZekdxnTFttfOgb+
	c1DA==
MIME-Version: 1.0
Received: by 10.66.87.133 with SMTP id ay5mr18218502pab.59.1348849357621; Fri,
	28 Sep 2012 09:22:37 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.68.16.40 with HTTP; Fri, 28 Sep 2012 09:22:37 -0700 (PDT)
In-Reply-To: <CAFZ_MYKEJnkMW=ZohxGMq2TmqYohJTY+O5goHzVJu0P1CZpucQ@mail.gmail.com>
References: <CAFZ_MYKEJnkMW=ZohxGMq2TmqYohJTY+O5goHzVJu0P1CZpucQ@mail.gmail.com>
Date: Fri, 28 Sep 2012 09:22:37 -0700
X-Google-Sender-Auth: CiDLjlU--rPSkogeIDiQ6bD66X0
Message-ID: <CAJ-Vmon7U+uH1FpBz6xswMa_5j5dngmobH2MekV4ey=MS9MfvA@mail.gmail.com>
From: Adrian Chadd <adrian@freebsd.org>
To: PseudoCylon <moonlightakkiy@yahoo.ca>
Content-Type: text/plain; charset=ISO-8859-1
Cc: freebsd-wireless@freebsd.org, Kim Culhan <w8hdkim@gmail.com>
Subject: Re: ath0_node_lock ath0_com_lock lor
X-BeenThere: freebsd-wireless@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussions of 802.11 stack,
	tools device driver development." <freebsd-wireless.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
	<mailto:freebsd-wireless-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-wireless>
List-Post: <mailto:freebsd-wireless@freebsd.org>
List-Help: <mailto:freebsd-wireless-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
	<mailto:freebsd-wireless-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Sep 2012 16:22:44 -0000

On 28 September 2012 07:03, PseudoCylon <moonlightakkiy@yahoo.ca> wrote:

>> Hm, that's odd. Who wants to go digging to figure out which code paths
>> are causing this? :)

> A suggestion
>
> in setmlme_dropsta()
> http://fxr.watson.org/fxr/source/net80211/ieee80211_ioctl.c#L1331
>
> Just forget about node lock and call ieee80211_find_node() instead of
> ieee80211_find_node_locked(). (I believe this lor occurs only in AP
> mode.)

Right, it's in the wiki, but I don't know what the two code paths are
that have inverted locks.

So would someone please map out the two code paths and where the locks
are grabbed, so I/we can think about how this should be better fixed?

Thanks,




Adrian