From owner-svn-src-all@freebsd.org Mon Oct 17 08:51:55 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8CC87C14F48; Mon, 17 Oct 2016 08:51:55 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-lf0-x22e.google.com (mail-lf0-x22e.google.com [IPv6:2a00:1450:4010:c07::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 185181D6A; Mon, 17 Oct 2016 08:51:55 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-lf0-x22e.google.com with SMTP id x79so283272071lff.0; Mon, 17 Oct 2016 01:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=sgtewpdQlM+6tABNogYlH1+/0Xcata628LVIguchCPY=; b=ZGkfd2d3BTmksVvpWh/5VFmRuky8Ha3MZbQImJd3rRZHPQYz9JxEjr8ZLHFJP38qek +U7eiPNUZFH/pOovkrz+3iXskOfV1L8f23A3QiSsZuJ/2Hu4pO/3YZqNh5/UmXEYbrFt 4POJel6zKB5GcnJpnrG08ey6fUGtpqPfU/PmVbIB041YObpsj9ow4TvxpjpiI3Xmw1Sl y7MoRaO1Wb+y05hG9gGElzxDPmxBQWgLf7ISm9z7FyVaiQngsqP8YJ+sVgtZxlsraOwO mP/3Nq/3il69oofvPbaRzahufR8BurEm1n95wa2N9YX6xK38q9rtA3S5+siGN/9GMf8a ah3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=sgtewpdQlM+6tABNogYlH1+/0Xcata628LVIguchCPY=; b=WqtqGiEthMDPT202Ucff2VZkBwbRT4dlsTtaur39zJ0LiCRLgeLNVNyDmsMjIomsdi RZVH/Flxr2WDuK1yUTDpfxGIaVO30xtzzJir6FFFdH9/gPbhggTG0GrzoO8H9Roxrri9 rBvXramY7MHFCcFG2UkmzGbRuvqUUo2P+SzWccp5IZnKZxg4vGqIvY19JEBBJvAreaS1 RJxPVtGsfjnk6iSJ+Tn7xu1IFKKB8s0H4Exr6MOLmV0A1JQYpNuZYQ16KV6S2tFU/Uq7 kOkKkRPJSq+ZRbgq3XxEZ/e/l0N9b74U3NUUo0BYsgKjXogGNbUfmWchoElBw5pi9zmJ HLzA== X-Gm-Message-State: AA6/9RklFawvuA+fIlhLPyHyCE0F8GzAe7bnyJVv1vtuDSb4vROZG13S1UpIIItXxIfv3g== X-Received: by 10.25.215.34 with SMTP id o34mr12232073lfg.35.1476694313243; Mon, 17 Oct 2016 01:51:53 -0700 (PDT) Received: from mavbook.mavhome.dp.ua ([134.249.139.101]) by smtp.gmail.com with ESMTPSA id h36sm7364736ljh.41.2016.10.17.01.51.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Oct 2016 01:51:52 -0700 (PDT) Sender: Alexander Motin Subject: Re: svn commit: r307507 - head/sys/cam/scsi To: Steven Hartland , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201610170835.u9H8ZvQi037190@repo.freebsd.org> <14e5b11b-d623-fe1b-2ad3-088961d1ffab@multiplay.co.uk> From: Alexander Motin Message-ID: <9d9c7a6a-74cf-e3f5-4aba-02e4ed636fbe@FreeBSD.org> Date: Mon, 17 Oct 2016 11:51:51 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <14e5b11b-d623-fe1b-2ad3-088961d1ffab@multiplay.co.uk> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2016 08:51:55 -0000 On 17.10.2016 11:45, Steven Hartland wrote: > IIRC the timeout for this was intentionally lower than the default, > might be worth just checking. I did traced back the commit history, and it was hardcoded to that value since the beginning 18 years ago. Theoretically SYNCHRONIZE CACHE may require even more time then WRITE, since nobody knows how big can be write caches and how many writes are sitting there. > On 17/10/2016 09:35, Alexander Motin wrote: >> Author: mav >> Date: Mon Oct 17 08:35:56 2016 >> New Revision: 307507 >> URL: https://svnweb.freebsd.org/changeset/base/307507 >> >> Log: >> Consider device as clean even if SYNCHRONIZE CACHE failed. >> >> If device reservation was preempted by other initiator, our sync request >> will always fail. Without this change CAM tried to sync cache on every >> following device close, including numerous GEOM tasting opens/closes, >> causing lots of useless noise in logs. >> >> While there, increase SYNCHRONIZE CACHE timeout to default value. >> >> MFC after: 2 weeks >> >> Modified: >> head/sys/cam/scsi/scsi_da.c >> >> Modified: head/sys/cam/scsi/scsi_da.c >> ============================================================================== >> --- head/sys/cam/scsi/scsi_da.c Mon Oct 17 08:29:16 2016 (r307506) >> +++ head/sys/cam/scsi/scsi_da.c Mon Oct 17 08:35:56 2016 (r307507) >> @@ -1488,12 +1488,11 @@ daclose(struct disk *dp) >> scsi_synchronize_cache(&ccb->csio, /*retries*/1, >> /*cbfcnp*/dadone, MSG_SIMPLE_Q_TAG, >> /*begin_lba*/0, /*lb_count*/0, SSD_FULL_SIZE, >> - 5 * 60 * 1000); >> + da_default_timeout * 1000); >> error = cam_periph_runccb(ccb, daerror, /*cam_flags*/0, >> /*sense_flags*/SF_RETRY_UA | SF_QUIET_IR, >> softc->disk->d_devstat); >> - if (error == 0) >> - softc->flags &= ~DA_FLAG_DIRTY; >> + softc->flags &= ~DA_FLAG_DIRTY; >> xpt_release_ccb(ccb); >> } >> >> > -- Alexander Motin