From owner-svn-src-projects@FreeBSD.ORG Mon Mar 4 20:17:37 2013 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 260BFC08; Mon, 4 Mar 2013 20:17:37 +0000 (UTC) (envelope-from davide.italiano@gmail.com) Received: from mail-ve0-f179.google.com (mail-ve0-f179.google.com [209.85.128.179]) by mx1.freebsd.org (Postfix) with ESMTP id A718C11B6; Mon, 4 Mar 2013 20:17:36 +0000 (UTC) Received: by mail-ve0-f179.google.com with SMTP id da11so5182433veb.10 for ; Mon, 04 Mar 2013 12:17:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=VyhHR9XDHfE2i3Kl/0llZ/ZNK2A66yW6foJXDfkm2/w=; b=ClxOclC75DIFaHXRS1OVcZhtzI2IO6L8rpnafE3HenMKsUtBbyzuLUIOFggkkvHfp0 asBV8jJ/loZX+GKKbH9/iExzRfOpZklzF3Hv8dqaoW7zbPgNPC6fi94wqC5obtUjoGN+ Hn38OuH2viqE7LAta1a0aAYON34PfhEJcaLJsUkYDLhz5cSsxAoL6Xbe/nNK9istTpJQ ivVGHIwMBHaPe+5L+gpba8mQlWP1DcmYOt0IHsUFppoAdGGD13Ax9s22AkPMhSNr4iYd m7h/G424u7CVyc5iZWkdYWeRrTImY6hU+ctQeongHYheJzYpHmcFVpKcNzodhva4dzWt vqTQ== MIME-Version: 1.0 X-Received: by 10.220.219.9 with SMTP id hs9mr8319497vcb.68.1362428250326; Mon, 04 Mar 2013 12:17:30 -0800 (PST) Sender: davide.italiano@gmail.com Received: by 10.220.34.203 with HTTP; Mon, 4 Mar 2013 12:17:30 -0800 (PST) In-Reply-To: <201303041040.41845.jhb@freebsd.org> References: <201303031339.r23DdsBU047737@svn.freebsd.org> <201303041040.41845.jhb@freebsd.org> Date: Mon, 4 Mar 2013 21:17:30 +0100 X-Google-Sender-Auth: ztpO_kumXEFu-Mbiy5K_ftZ5A40 Message-ID: Subject: Re: svn commit: r247710 - projects/calloutng/sys/kern From: Davide Italiano To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-projects@freebsd.org, Attilio Rao , src-committers@freebsd.org X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Mar 2013 20:17:37 -0000 On Mon, Mar 4, 2013 at 4:40 PM, John Baldwin wrote: > On Sunday, March 03, 2013 8:39:54 am Davide Italiano wrote: >> Author: davide >> Date: Sun Mar 3 13:39:54 2013 >> New Revision: 247710 >> URL: http://svnweb.freebsd.org/changeset/base/247710 >> >> Log: >> - Use TRUE/FALSE in lieu of 0/1 for boolean_t variables. > > We have stdbool in the kernel. Why not use that instead of the Machish > boolean_t? > > -- > John Baldwin It was originally int, and a couple of days ago Attilio suggested to move to 'boolean_t'. Honestly, I didn't argue due to the relative little relevance of the change, but actually I find the type change more explicative. I have no strong objections to change it again (in particular because I think you're suggesting to use bool to be C99 compliant, feel free to correct me if I'm wrong). While here. After closer looking I realized boolean_t is widely used in the kernel (e.g. sys/kern/). Is this just a common error or is there something I'm missing? Thanks -- Davide