From owner-p4-projects@FreeBSD.ORG  Fri Jun  8 17:53:05 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 85DEC16A41F; Fri,  8 Jun 2007 17:53:05 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 148B816A46B;
	Fri,  8 Jun 2007 17:53:05 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.freebsd.org (Postfix) with ESMTP id B630A13C45E;
	Fri,  8 Jun 2007 17:53:04 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l58HqrOn058477;
	Fri, 8 Jun 2007 13:52:59 -0400 (EDT) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: attilio@freebsd.org
Date: Fri, 8 Jun 2007 13:51:52 -0400
User-Agent: KMail/1.9.6
References: <200706021756.l52Huq9A049371@repoman.freebsd.org>
	<86myzeq67f.wl%rpaulo@fnop.net> <4666B730.9080908@FreeBSD.org>
In-Reply-To: <4666B730.9080908@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200706081351.54281.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]);
	Fri, 08 Jun 2007 13:52:59 -0400 (EDT)
X-Virus-Scanned: ClamAV 0.88.3/3380/Fri Jun 8 08:34:26 2007 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 
	autolearn=ham version=3.1.3
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx
Cc: Rui Paulo <rpaulo@fnop.net>, Perforce Change Reviews <perforce@freebsd.org>,
	Rui Paulo <rpaulo@freebsd.org>
Subject: Re: PERFORCE change 120788 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Jun 2007 17:53:05 -0000

On Wednesday 06 June 2007 09:31:28 am Attilio Rao wrote:
> Rui Paulo wrote:
> > 
> > If I'm not doing something wrong, I need to use spin locks on my
> > interrupt handler, or else witness_checkorder will complain with
> > "blockable sleep lock".
> > 
> > Note that I'm using FILTERs.
> 
> So you are doing this in the wrong way.
> In order to use correctly filters, please note that the support for them 
> is compile time choosen, so you need to wrapper all filter specific 
> parts using INTR_FILTER compat macro.

Actually, if you only use a filter and not an ithread handler, you can do that 
now w/o needing to have any #ifdef INTR_FILTER stuff.

-- 
John Baldwin