Date: Wed, 14 Jan 2004 18:37:47 +0100 From: Matthias Andree <matthias.andree@gmx.de> To: FreeBSD-gnats-submit@FreeBSD.org Cc: ache@FreeBSD.org Subject: ports/61366: [PATCH] archivers/unzip: fix bogus pkg-plist Message-ID: <E1Agoxe-000AV7-VX@libertas.emma.line.org> Resent-Message-ID: <200401141740.i0EHe3sB020495@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 61366
>Category: ports
>Synopsis: [PATCH] archivers/unzip: fix bogus pkg-plist
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Jan 14 09:40:03 PST 2004
>Closed-Date:
>Last-Modified:
>Originator: Matthias Andree
>Release: FreeBSD 4.9-STABLE i386
>Organization:
>Environment:
System: FreeBSD libertas.emma.line.org 4.9-STABLE FreeBSD 4.9-STABLE #73: Mon Jan 12 16:07:47 CET 2004
>Description:
The current @exec/@unexec stuff is bogus.
1. it discards an error condition without reason
2. it does not properly "silence" rm errors as the last commit suggests,
the redirection parameters are reversed. rm's stdout goes down the
drain, rm's stderr appears on pkg_delete's stdout.
3. there is no reason to use @exec/@unexec in the first place
The patch below
A. replaces @exec/@unexec by just bin/zipinfo
B. avoids two bogus portlint "possible direct use of file(1)"
warnings by using "f" instead of "file" for iterator variable, two
more warnings remain unaddressed by this patch.
Port maintainer (ache@FreeBSD.org) is cc'd.
Generated with FreeBSD Port Tools 0.50
>How-To-Repeat:
>Fix:
--- unzip-5.50_2.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/archivers/unzip/Makefile /root/ports/archivers/unzip/Makefile
--- /usr/ports/archivers/unzip/Makefile Wed Oct 29 12:42:09 2003
+++ /root/ports/archivers/unzip/Makefile Wed Jan 14 18:32:49 2004
@@ -54,13 +54,13 @@
.endfor
${LN} -sf unzip ${PREFIX}/bin/zipinfo
${INSTALL_SCRIPT} ${WRKSRC}/unix/zipgrep ${PREFIX}/bin
-.for file in ${MAN1}
- ${INSTALL_MAN} ${WRKSRC}/man/${file} ${PREFIX}/man/man1
+.for f in ${MAN1}
+ ${INSTALL_MAN} ${WRKSRC}/man/${f} ${PREFIX}/man/man1
.endfor
.if !defined(NOPORTDOCS)
@${MKDIR} ${PREFIX}/share/doc/unzip
-.for file in README WHERE
- ${INSTALL_DATA} ${WRKSRC}/${file} ${PREFIX}/share/doc/unzip
+.for f in README WHERE
+ ${INSTALL_DATA} ${WRKSRC}/${f} ${PREFIX}/share/doc/unzip
.endfor
.endif
diff -ruN --exclude=CVS /usr/ports/archivers/unzip/pkg-plist /root/ports/archivers/unzip/pkg-plist
--- /usr/ports/archivers/unzip/pkg-plist Wed Oct 29 12:42:09 2003
+++ /root/ports/archivers/unzip/pkg-plist Wed Jan 14 18:29:17 2004
@@ -1,9 +1,8 @@
bin/unzip
-@exec ln -sf %f %B/zipinfo
-@unexec rm %D/bin/zipinfo 2>&1 >/dev/null || true
bin/funzip
bin/unzipsfx
bin/zipgrep
+bin/zipinfo
%%PORTDOCS%%%%DOCSDIR%%/README
%%PORTDOCS%%%%DOCSDIR%%/WHERE
%%PORTDOCS%%@dirrm %%DOCSDIR%%
--- unzip-5.50_2.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E1Agoxe-000AV7-VX>