From owner-freebsd-bugs@freebsd.org Tue Apr 11 17:29:48 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 00505D39643 for ; Tue, 11 Apr 2017 17:29:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CC0811E91 for ; Tue, 11 Apr 2017 17:29:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v3BHTl7p057102 for ; Tue, 11 Apr 2017 17:29:47 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 218568] vdev_geom_attach_by_guids can attach to wrong partition Date: Tue, 11 Apr 2017 17:29:47 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: asomers@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Apr 2017 17:29:48 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218568 Bug ID: 218568 Summary: vdev_geom_attach_by_guids can attach to wrong partition Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: asomers@FreeBSD.org When opening a vdev whose path is unknown, vdev_geom must find a geom provi= der with a label whose guids match te desired vdev. However, due to partitioni= ng, it is possible that two non-synonomous providers will share two labels. For example, if the first partition starts at the beginning of the drive, then = ada0 and ada0p1 will share the first label. More troubling, if the last partiti= on runs to the end of the drive, then ada0p3 and ada0 will share the last labe= l.=20 If vdev_geom opens ada0 when it should've opened ada0p3, then the pool won'= t be readable. If it opens ada0 when it should've opened ada0p1, then it will corrupt some other partition when it writes the 3rd and 4th labels. The easiest way to observe this problem is to install ZFS to a pair of mirr= ored drives, using the default GPT partitioning scheme. Power off, swap the dri= ves, and power back on. Depending on the order that geom probes its providers, = ZFS may or may not attach to the correct partitions. If it doesn't, then impor= ting the pool will fail somewhere up stack, and the system will be left at the mountroot> prompt. --=20 You are receiving this mail because: You are the assignee for the bug.=