From owner-svn-src-all@FreeBSD.ORG Wed May 23 19:57:38 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7880B1065672; Wed, 23 May 2012 19:57:38 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 03C4D8FC16; Wed, 23 May 2012 19:57:36 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id WAA26437; Wed, 23 May 2012 22:57:29 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1SXHgX-0002dC-4d; Wed, 23 May 2012 22:57:29 +0300 Message-ID: <4FBD4124.5030205@FreeBSD.org> Date: Wed, 23 May 2012 22:57:24 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:12.0) Gecko/20120503 Thunderbird/12.0.1 MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <201205231817.q4NIH2t7088267@svn.freebsd.org> <20120523192232.GA1399@garage.freebsd.pl> In-Reply-To: <20120523192232.GA1399@garage.freebsd.pl> X-Enigmail-Version: 1.5pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Xin LI Subject: Re: svn commit: r235852 - head/sys/geom X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 May 2012 19:57:38 -0000 on 23/05/2012 22:22 Pawel Jakub Dawidek said the following: > On Wed, May 23, 2012 at 06:17:02PM +0000, Xin LI wrote: >> Author: delphij Date: Wed May 23 18:17:02 2012 New Revision: 235852 URL: >> http://svn.freebsd.org/changeset/base/235852 >> >> Log: Use %ju to match uintmax_t usage >> >> Modified: head/sys/geom/geom_flashmap.c >> >> Modified: head/sys/geom/geom_flashmap.c >> ============================================================================== >> >> --- head/sys/geom/geom_flashmap.c Wed May 23 18:11:36 2012 (r235851) >> +++ head/sys/geom/geom_flashmap.c Wed May 23 18:17:02 2012 (r235852) @@ >> -78,7 +78,7 @@ static void g_flashmap_print(struct g_flashmap_slice >> *slice) { >> >> - printf("%08jx-%08jx: %s (%lluKB)\n", (intmax_t)slice->sl_start, >> (intmax_t)slice->sl_end, + printf("%08jx-%08jx: %s (%juKB)\n", >> (intmax_t)slice->sl_start, (intmax_t)slice->sl_end, slice->sl_name, >> (uintmax_t)(slice->sl_end - slice->sl_start) / 1024); > > BTW, %jx is also uintmax_t, not intmax_t, right? > I think that non-decimal representation generally implies unsigned-ness. -- Andriy Gapon