From owner-svn-src-all@freebsd.org Sun Mar 5 00:36:28 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 09FC5CEC544; Sun, 5 Mar 2017 00:36:28 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BE40A1358; Sun, 5 Mar 2017 00:36:27 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by freefall.freebsd.org (Postfix, from userid 1235) id 1C87E4752; Sun, 5 Mar 2017 00:36:27 +0000 (UTC) Date: Sun, 5 Mar 2017 01:36:26 +0100 From: Baptiste Daroussin To: Warner Losh Cc: rgrimes@freebsd.org, Ngie Cooper , Bryan Drewery , Ngie Cooper , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r314657 - in head/kerberos5: . lib/libgssapi_krb5 lib/libgssapi_ntlm lib/libgssapi_spnego lib/libhdb lib/libkafs5 lib/libkrb5 libexec/hprop libexec/kpasswdd tools/asn1_compile tools/slc Message-ID: <20170305003626.dvdp4msi36pyqxbn@ivaldir.net> References: <201703042232.v24MW9jt079229@pdx.rh.CN85.dnsmgr.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mfviljg5nubnmw4n" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170225 (1.8.0) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Mar 2017 00:36:28 -0000 --mfviljg5nubnmw4n Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 04, 2017 at 05:16:49PM -0700, Warner Losh wrote: > On Sat, Mar 4, 2017 at 3:32 PM, Rodney W. Grimes > wrote: > >> > >> > On Mar 4, 2017, at 13:43, Warner Losh wrote: > >> > > >> >> On Sat, Mar 4, 2017 at 1:25 PM, Bryan Drewery wrote: > >> >>> On 3/4/2017 12:20 PM, Rodney W. Grimes wrote: > >> >>> -- Start of PGP signed section. > >> >>> [ Charset windows-1252 unsupported, converting... ] > >> >>>>> On 3/4/2017 7:34 AM, Rodney W. Grimes wrote: > >> >>>>> What is ${.CURDIR:H:H} ????? Yes that seems to work but now we = are obscuring > >> >>>>> ../.. into makefile syntax magic, probably not a grand idea. > >> >>>> It just trims off the last directory component. This both reduces > >> >>>> namecache lookups, lessens the amount of data in a log, and makes > >> >>>> debugging a log simpler by not having a crazy path like: > >> >>>> /home/bdrewery/big/git/buildserver/sys/modules/usb/template/../..= /../dev/usb/template/usb_template.c > >> >>>> > >> >>>> It's far simpler to understand and work with: > >> >>>> /home/bdrewery/big/git/buildserver/sys/dev/usb/template/usb_templ= ate.c > >> >>>> > >> >>>> The only downside is it is slightly more obscure in a Makefile, b= ut once > >> >>>> you know what :H is then it's not a problem. This is why SRCTOP = is even > >> >>>> better than this as it is far more clear than even :H and avoids = the > >> >>>> ../../ problems. > >> >>> Lets do one or the other, but not both ${SRCTOP} and :H:H:H. It a= ppears > >> >>> that we now have a mix and mashed up some one way others the other. > >> >> > >> >> That I can agree with. I would prefer to standardize on SRCTOP as := H is > >> >> too obscure without learning about make details. > >> > > >> > :H is insane in 90% of the cases I've seen it used. Let's roll with > >> > SRCTOP everywhere we can. That's safer from directory motion anyway.= =2E. > >> > >> Ok, I have 3 votes for SRCTOP, so I'll implement the remaining change = using SRCTOP (for usr.bin), and reimplement the previous changes using SRCT= OP. > > > > And that some how over rides the 3 votes for not doing any of these cha= nges? > > Slow down please. We dont need a bike shed, but I think we need a clear > > target and a consense larger than 3+ 3- and less than a 6 hour wall clo= ck > > of discussion. > > > > It would also be best if it was this change and only this change commit= ted > > in very large (preferably about 20) commits. >=20 > We've had about 200-300 commits in the build system in the past year. > There's no real need to slow down. It's a real mess (though a lot less > of one thanks to Bryan) and SRCTOP is a definite cleanup. >=20 I totally agree with Warner on all points :) Bapt --mfviljg5nubnmw4n Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAli7XYcACgkQY4mL3PG3 Ploulw/+KuNFRCf56PLnuiUPRPfxOM8smmIoUbGESdW6B4kuwqRHhyL8H7O/zg54 xk4zWvfkRN/g8gXmTsDqU41ohDroCIQc6E9Kc5h9OEVherUFsLgtZKD56kemKvLU tHkRU9wdALm0I7NtS1ETBvu3z0h9kRYIEHrYxa/l9qodhBJlhdlG2GUiQD+mwdlJ zW8FdmuiE+h+cv5rMvNyNIfdzcOV6TJATQbQATn2X619tq+JjSWELtaYbpBlW1ny U/WgJFPpv1KCaHpxPOn144KtkSTnPg9r7W6q+QvHNo+YmlFjC9haBtkn3IV64MKv U+uwC710zMhMPfbK/ZfurAa7TYBlQF+rqrbPDI4UmNaptkrEa+DYO4LiCNyb6WOl H9yf85z3ovlrKymS/Ne/ZFMEo+fn8Z7AsDwbzqH6xioLjhn6rbeviBNGRXgW4iwX +sRkG5rpZcDbt7CBN/iV2nE0Kr2qZ85HfxCvVPzT7cYgt6e8CGobyAFFtvj6HGmG V/b7NSty2gyW7O+XQHTKz/gAGF1ZsHDnpNBL1A/AY8dhPRgs8ihH/aYgBclLL3NH SJjbeuO5sHwA/0rnkD0xGoH7FIdRB0I/bYM1HpAcrdJzbktyrOGytII9uhBE34t1 jSizhy0v5OWStXM16f5K0JGmqBzgeseNvZhWXOiPMlKfc3PvCyI= =/+nM -----END PGP SIGNATURE----- --mfviljg5nubnmw4n--