From owner-p4-projects@FreeBSD.ORG  Sun Nov 14 11:31:59 2004
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 86D9116A4D2; Sun, 14 Nov 2004 11:31:59 +0000 (GMT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 60E2016A4CE; Sun, 14 Nov 2004 11:31:59 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 5326F43D46; Sun, 14 Nov 2004 11:31:59 +0000 (GMT)
	(envelope-from davidxu@freebsd.org)
Received: from [127.0.0.1] (davidxu@localhost [127.0.0.1])
	iAEBVsQ2051139;	Sun, 14 Nov 2004 11:31:57 GMT
	(envelope-from davidxu@freebsd.org)
Message-ID: <4197422A.4020905@freebsd.org>
Date: Sun, 14 Nov 2004 19:31:54 +0800
From: David Xu <davidxu@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040921
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Brian Fundakowski Feldman <green@freebsd.org>
References: <200411140513.iAE5DOTv056478@repoman.freebsd.org>
	<20041114062748.GH997@green.homeunix.org>
In-Reply-To: <20041114062748.GH997@green.homeunix.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 65074 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Nov 2004 11:32:00 -0000

Brian Fundakowski Feldman wrote:

>On Sun, Nov 14, 2004 at 05:13:24AM +0000, David Xu wrote:
>  
>
>>http://perforce.freebsd.org/chv.cgi?CH=65074
>>
>>Change 65074 by davidxu@davidxu_alona on 2004/11/14 05:12:40
>>
>>	1. Fix a race between signal and umtx_unlock. a waiter
>>	   may be resumed by signal and left or exited, heavily
>>	   loaded test causes kernel to crash.
>>	2. Use distributed queue locks instead of single giant
>>	   lock.
>>    
>>
>
>This sounds like it could be why recently valgrind has grown broken,
>and is now entirely non-working and someimes crashes the system?
>
>  
>
Both have bug, valgrind seems have lock leak, umtx code
has race condition.

David Xu