From owner-freebsd-ports-bugs@freebsd.org Sat Aug 29 21:48:42 2015 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 31A7F9C4675 for ; Sat, 29 Aug 2015 21:48:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 180398FD for ; Sat, 29 Aug 2015 21:48:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t7TLmfwU065629 for ; Sat, 29 Aug 2015 21:48:41 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 202404] [MAINTAINER] multimedia/mplayer2: updates to Makefile Date: Sat, 29 Aug 2015 21:48:42 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jbeich@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Aug 2015 21:48:42 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202404 Jan Beich changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|In Progress |Closed --- Comment #41 from Jan Beich --- Thanks for patience. Committed. I've fixed the rest myself. > -.if !defined(PACKAGE_BUILDING) > OPTIONS_DEFINE_i386+=3D WIN32 > OPTIONS_DEFAULT_i386+=3D WIN32 > -.endif win32-codecs is a RESTRICTED package thus will make any port that depends on it broken due to unsatisfied dependency. The check originates from bug 115170 for mplayer. _OFF option helper won't trigger if the option isn't defined via _DEFINE*, _SINGLE, etc. That's why I've moved OPTIONS_DEFINE_i386 outside of PACKAGE_BUILDING in comment 2. Thus package cluster makes sure to provide --disable-win32dll when building for i386, the only architecture where configure tries to auto-enable it. > OPTIONS_DEFAULT=3D... RTCPU ... Did you check on either arm*, aarch64, mips*, ia64, sparc64 ? --enable-runtime-cpudetection is only supported on x86 and ppc which translates to i386, amd64, powerpc, powerpc64 on FreeBSD. On other architectures configure calls die() i.e., exits with error message quoted in comment 37. > -V4L_LIBS=3D -lv4l2 > +V4L_LIBS=3D -lv4l1 -lv4l2 libv4l2 usage is inflicted by files/patch-stream-tvi_v4l2.c. Upstream only uses which is part of V4L2 API. Nothing in mplayer2 uses aka V4L1 API not to mention . Explain if you think otherwise. > -.if ${PORT_OPTIONS:MREALPLAYER} > -RUN_DEPENDS+=3D realplay:${PORTSDIR}/multimedia/linux-realplayer > -BUILD_DEPENDS+=3D realplay:${PORTSDIR}/multimedia/linux-realplayer > -.else > -CONFIGURE_ARGS+=3D --disable-real > -.endif > +REALPLAYER_BUILD_DEPENDS=3Drealplay:${PORTSDIR}/multimedia/linux-realpla= yer > +REALPLAYER_CONFIGURE_OFF=3D--disable-real RUN_DEPENDS are lost in conversion. > WITH_CDROM_DEVICE?=3D /dev/cd0 This is still referenced. > -.if defined(WITH_KERN_HZ) > -DEFAULT_KERN_HZ=3D${WITH_KERN_HZ} > -.else > -DEFAULT_KERN_HZ=3D1024 > -.endif Did you ignore the build error I reported in comment 37 ? > - @${REINPLACE_CMD} -e \ > - 's|irqp =3D 1024|irqp =3D ${DEFAULT_KERN_HZ}|' \ > - ${WRKSRC}/mplayer.c > + @${REINPLACE_CMD} -e \ > + 's|irqp =3D 1024|irqp =3D ${DEFAULT_KERN_HZ}|' \ > + ${WRKSRC}/mplayer.c Pointless reindenting causes noise for |svn blame|. --=20 You are receiving this mail because: You are the assignee for the bug.=