From nobody Sat Oct 7 21:36:48 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S2zCJ3cNCz4wVCy; Sat, 7 Oct 2023 21:37:00 +0000 (UTC) (envelope-from christos@freebsd.org) Received: from margiolis.net (mail.margiolis.net [95.179.159.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4S2zCH3KNsz4ZJD; Sat, 7 Oct 2023 21:36:59 +0000 (UTC) (envelope-from christos@freebsd.org) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=mail; bh=Or9pPaegt9hK8oZ 8GK2biAQsBQkyjqmFic+SaqPjMzs=; h=in-reply-to:references:subject:cc:to: from:date; d=margiolis.net; b=Y6hBLVi94plj7wOGbkpc3lfxoDSMAZVqzZXt773B JUavCLYm4EF81FAPPXOiFOr+y3y1h1C1i5pocrfswiip3tCplpDIJJAFv2Kewuj0h1HEv2 yErb78eeOEn+08pAVvb6zEmiEZsUw8JiQUKoZd0tn8PxfeEHyUR/RSTnCpVtM= Received: from pleb (ppp-94-66-59-115.home.otenet.gr [94.66.59.115]) by margiolis.net (OpenSMTPD) with ESMTPSA id 5b5587ea (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sat, 7 Oct 2023 21:36:50 +0000 (UTC) Date: Sun, 8 Oct 2023 00:36:48 +0300 From: Christos Margiolis To: Dima Panov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 9e589b093857 - main - tty: fix improper backspace behaviour for UTF8 characters when in canonical mode Message-ID: References: <202310071800.397I0p9G047831@gitrepo.freebsd.org> <816f8408-865a-488f-a139-ad4bae2301fb@FreeBSD.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <816f8408-865a-488f-a139-ad4bae2301fb@FreeBSD.org> X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:20473, ipnet:95.179.144.0/20, country:US] X-Rspamd-Queue-Id: 4S2zCH3KNsz4ZJD Dima Panov wrote: > It breaks the build %( > > > In file included from /usr/local/poudriere/jails/150aarch64/usr/src/sys/teken/teken.c:70: > /usr/local/poudriere/jails/150aarch64/usr/src/sys/teken/teken_wcwidth.h:132:7: error: call to undeclared function 'bitcount'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] > if (bitcount(bytes[0] & 0xf0) != nbytes) > ^ > 1 error generated. > *** [teken.o] Error code 1 The cross builds had succeeded on GitHub's Actions, our local machines and the FreeBSD cluster, so we thought it was good to go. Apparently, the code should call __bitcount() which is defined in sys/types.h (included in teken/teken.h), instead of bitcount(), which is defined in sys/libkern.h and is not included. I am pushing a fix right now. Unfortunately, since all the machines I keep trying to clean build on succeed, we'll have to wait for feedback again to be sure that the fix is working... Christos