From owner-freebsd-current@FreeBSD.ORG Sat Jul 11 20:39:04 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9145F10656E4 for ; Sat, 11 Jul 2009 20:39:04 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from asmtpout023.mac.com (asmtpout023.mac.com [17.148.16.98]) by mx1.freebsd.org (Postfix) with ESMTP id 743B68FC12 for ; Sat, 11 Jul 2009 20:39:04 +0000 (UTC) (envelope-from xcllnt@mac.com) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=us-ascii; format=flowed; delsp=yes Received: from macbook-pro.lan.xcllnt.net (mail.xcllnt.net [75.101.29.67]) by asmtp023.mac.com (Sun Java(tm) System Messaging Server 6.3-8.01 (built Dec 16 2008; 32bit)) with ESMTPSA id <0KMM00DEXXD37F10@asmtp023.mac.com> for freebsd-current@freebsd.org; Sat, 11 Jul 2009 13:39:04 -0700 (PDT) From: Marcel Moolenaar In-reply-to: Date: Sat, 11 Jul 2009 13:39:03 -0700 Message-id: References: <20090710042106.GC31950@rwpc12.mby.riverwillow.net.au> <20090710071023.GB32316@rwpc12.mby.riverwillow.net.au> <20090710112631.GE32316@rwpc12.mby.riverwillow.net.au> <3a142e750907100433y307f9b2bya1dc54953bdf5de2@mail.gmail.com> <0B1F6799-2FAC-4C01-A978-42E247979CAB@mac.com> <1z5niluEh3OBPNSdMbOMyoEwzX4@CWODRlDR5RMqbkBfR0/UzHcfNhE> <267A655F-13A6-4D79-A933-3A78854AC5FD@mac.com> To: rea-fbsd@codelabs.ru X-Mailer: Apple Mail (2.1070) Cc: freebsd-current@freebsd.org, John Marshall Subject: Re: 8.0-BETA1 bsdlabel broken? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jul 2009 20:39:04 -0000 On Jul 11, 2009, at 11:15 AM, Eygene Ryabinkin wrote: > > OK, the attached patch should solve the issue in the bsdlabel: > it really uses the offset of the 'c' partition to make offsets > to be relative. Yes, that's the idea. I would add a safety check though: even though the 'c' partition is defined and reserved to mean the whole disk, there's nothing preventing creative souls from using the 'c' partition for something else. I would add a check to make sure that the offset of the 'c' partition is less than or equal to any of the offsets in the partition table before subtracting. >> As a special warning: you should not have both GEOM_PART_BSD >> and GEOM_BSD. My gut feeling tells me that you have both and >> that's why you have the mess you're having. > > Then I would add a bit stronger warning about the GEOM_BSD into > /usr/src/UPDATING -- the current one (from 20090320) is rather mild in > respect of the obsoletenness of GEOM_BSD. And since GEOM_PART_* > seem to > be included by-default, it will produce the mess I had seen when > GEOM_BSD is included too. It will be good to embed the checks for > incompatible options into config(8). I'll draft the needed patches > for config(8). I think It's better to remove the options (and code) altogether. -- Marcel Moolenaar xcllnt@mac.com