From owner-cvs-all@FreeBSD.ORG  Fri Jul 27 21:39:06 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7C0A916A417
	for <cvs-all@FreeBSD.org>; Fri, 27 Jul 2007 21:39:06 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5])
	by mx1.freebsd.org (Postfix) with SMTP id 137AD13C4A6
	for <cvs-all@FreeBSD.org>; Fri, 27 Jul 2007 21:39:05 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: (qmail 11192 invoked by uid 399); 27 Jul 2007 21:39:05 -0000
Received: from localhost (HELO ?192.168.0.4?) (dougb@dougbarton.us@127.0.0.1)
	by localhost with ESMTP; 27 Jul 2007 21:39:05 -0000
X-Originating-IP: 127.0.0.1
Message-ID: <46AA65F6.2000204@FreeBSD.org>
Date: Fri, 27 Jul 2007 14:39:02 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Thunderbird 2.0.0.5 (Windows/20070716)
MIME-Version: 1.0
To: Rong-En Fan <rafan@FreeBSD.org>
References: <200707271159.l6RBxTwp090951@repoman.freebsd.org>
In-Reply-To: <200707271159.l6RBxTwp090951@repoman.freebsd.org>
X-Enigmail-Version: 0.95.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, Chris Cowart <ccowart@rescomp.berkeley.edu>,
	cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/net-mgmt/net-snmp4 Makefile pkg-plist     
 ports/net-mgmt/net-snmp4/files snmpd.in snmpd.sh.sample
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Jul 2007 21:39:06 -0000

Rong-En Fan wrote:
> rafan       2007-07-27 11:59:29 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     net-mgmt/net-snmp4   Makefile pkg-plist 
>   Added files:
>     net-mgmt/net-snmp4/files snmpd.in 
>   Removed files:
>     net-mgmt/net-snmp4/files snmpd.sh.sample 
>   Log:
>   - Convert to rc.d style script
>   - Bump PORTREVISION
>   
>   Note that I changed few places of the patch to match Porter's Handbook.
>   
>   PR:             ports/114952  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=114952
>   Submitted by:   Chris Cowart <ccowart at rescomp.berkeley.edu>
>   
>   Revision  Changes    Path
>   1.106     +2 -6      ports/net-mgmt/net-snmp4/Makefile
>   1.1       +26 -0     ports/net-mgmt/net-snmp4/files/snmpd.in (new)
>   1.2       +0 -20     ports/net-mgmt/net-snmp4/files/snmpd.sh.sample (dead)
>   1.24      +0 -1      ports/net-mgmt/net-snmp4/pkg-plist
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/net-snmp4/Makefile.diff?&r1=1.105&r2=1.106&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/net-snmp4/files/snmpd.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/net-snmp4/files/snmpd.sh.sample
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/net-snmp4/pkg-plist.diff?&r1=1.23&r2=1.24&f=h

This looks good overall. One question, it looks like this script is
starting a service, would it benefit from the shutdown KEYWORD?

Doug

-- 

    This .signature sanitized for your protection