From owner-freebsd-hackers@FreeBSD.ORG  Thu Aug  9 16:12:49 2012
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 95E071065672
	for <freebsd-hackers@freebsd.org>; Thu,  9 Aug 2012 16:12:49 +0000 (UTC)
	(envelope-from imp@bsdimp.com)
Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com
	[209.85.214.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 537D78FC0A
	for <freebsd-hackers@freebsd.org>; Thu,  9 Aug 2012 16:12:48 +0000 (UTC)
Received: by obbun3 with SMTP id un3so1123160obb.13
	for <freebsd-hackers@freebsd.org>; Thu, 09 Aug 2012 09:12:48 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=google.com; s=20120113;
	h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc
	:content-transfer-encoding:message-id:references:to:x-mailer
	:x-gm-message-state;
	bh=nKXzlXMRuDCxSrHsHG5Bnvr9LxuMtVmW9ErQI21B6lI=;
	b=HEf4dZN4p1+d5e5lPXXpzfeuugoHD9K6PM2ObYJbXws0Ux29VtlbEKiOeMGYTogq0N
	H8XMlkUaEV4fKNGOVkd+3rygVGmjPxMKLnY7RMzrRO9lYEBwFXs04mOL0dbYpnWA/p2Z
	1Xq81t+zym6Xesy+Hp/ecDn4S6mZAlq0a/n7FSLqU2mmILchniKQx7nByG5crVU7xIzj
	/kk14fzYodF5SKoXMbHk7gsx1ujcjwtPajGYfqX+xXAxZI77pla3OwpN1fFHahlF9yC7
	4YQI7SHIgMlr7/U+N23O6edTIZpbgbNdGeYFj73IfNoUAOmpEIgkWqlevLZjqK67xrRX
	Jqgg==
Received: by 10.182.53.103 with SMTP id a7mr36625014obp.3.1344528768366;
	Thu, 09 Aug 2012 09:12:48 -0700 (PDT)
Received: from [10.30.101.53] ([209.117.142.2])
	by mx.google.com with ESMTPS id bp7sm1159272obc.12.2012.08.09.09.12.45
	(version=TLSv1/SSLv3 cipher=OTHER);
	Thu, 09 Aug 2012 09:12:47 -0700 (PDT)
Sender: Warner Losh <wlosh@bsdimp.com>
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <CACS+7ZSu5FuBfXDvJXXYX+_ugmYGDfvut9PrdmRX4zkxLmxnvg@mail.gmail.com>
Date: Thu, 9 Aug 2012 10:12:44 -0600
Content-Transfer-Encoding: quoted-printable
Message-Id: <538F7D01-690B-46A3-982D-F2BF9EFE8621@bsdimp.com>
References: <CACS+7ZSu5FuBfXDvJXXYX+_ugmYGDfvut9PrdmRX4zkxLmxnvg@mail.gmail.com>
To: Dan McGregor <danismostlikely@gmail.com>
X-Mailer: Apple Mail (2.1084)
X-Gm-Message-State: ALoCoQmv0AQrnz3Slsc9ClSnZW/NiKGQZMa66LA/mUqKRmzlkc5Wb/TqCgzoxwF8rfn/ufF6tMMv
Cc: freebsd-hackers@freebsd.org
Subject: Re: Consistent use of lex flags
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Aug 2012 16:12:49 -0000

All these changes look good.  Since they aren't changes to lex itself, =
but how the base uses standard lex interfaces, I'd say we should just =
commit it.

Warner


On Aug 8, 2012, at 2:59 PM, Dan McGregor wrote:

> Hi.
>=20
> I was just noticing that mkcsmapper doesn't build with clang.  I saw =
two
> ways to do this, the first being to #define YY_NO_INPUT, and the other =
to
> use the %option noinput lex flag.
>=20
> While there, I decided to explore and I changed a bunch of #defines to =
the
> standard lex way of doing things.  I thought it would be good if all =
the
> code that originated in FreeBSD could be consistent.
>=20
> Thoughts?
> <lex.diff>_______________________________________________
> freebsd-hackers@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
> To unsubscribe, send any mail to =
"freebsd-hackers-unsubscribe@freebsd.org"