From nobody Sun Feb 2 16:58:52 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YmG7039Zrz5mRbG; Sun, 02 Feb 2025 16:58:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YmG702hYMz3j7J; Sun, 02 Feb 2025 16:58:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738515532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZgnfzDsBbEejHeA36xdRm6godJ5UboltUaY1cVZQsRY=; b=iKVNqGVIUbrmA/JwhGyqg0YKyjqYsF4qLWikC5zfn/B8Wj0kgOzKVMzi7NM7mnAeu96hzv ls/KVLuAENuH+UQBWXsKmN8hMTq+Pqth5nTKmjy9NYWbfGNeRALaNunnJGkCWkEPw1ZKrM 7bWim2y9pBSFq7H8ylc4YZGuLj7BFf2crbVnPFc7GzQZid73YuZLLpJBUhU3vTxDR4Sxko +nEgBLxsB96aAofaBg1ZwqkNKitIfawB4YnjuihQeuKKb6C5dpHTyTffGNve0K0bMxkCUm mrzs6sZT4LUwGhspEHrIGMy4VfUE80lHk5f3LOSDkKS4Urh5Xvbh3fXT5Vbmlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738515532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZgnfzDsBbEejHeA36xdRm6godJ5UboltUaY1cVZQsRY=; b=JpuIc6xWv5YI8r42H5gMyBxUWWQmmNqdvJFXBatmUwt/vHaTKFe7Oy/kriBenCC0OB/FJY Mgd01hvJsWEjjE8btiKeoz8liJXLmJ89UlHSb5R/1SjYlb10Hr68fh4wwM43x8tQKzflUe boXridKarl5DdnmEeRiyRJjrejY/nVzK70og+7llRUspeGIWtalA1Qq6YgzwYXI9kyeCf4 5+txM+jY/4N7hgU7Z9sNX1DKyge88xCp0iiLc7BQVpFHbS5JjBS5NWf7QVdiQuItQuULt5 KuFYF3szWWg5Llj4UzI/BU/IFexETP7uMgF4qxjVh5ZAgUzkPgJMgJ29KSVghg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738515532; a=rsa-sha256; cv=none; b=jTpr4/tX/SLe+7oMXPLDXK8dJpBtjnrL1iVkVn5V/8xRVKxg1vjZlEdAizuDYSo0ZBydAj CCjXPtkH0H4T7lP3QdMYj1cJ2mU/7vMMWsh+rA+BWz8TCcVK1e8oS46ciJ0eZ0VHgw8LNm KU5u8MRe5aEYvr5FR4wqQSTW55VyF8npPevFz5Z4QRFexffBrmflhlUZHqemrKXyQQNRKp Kn19oKtVCQNw5Hsgg9BV/skaq+igEmHG8TLBF6utwdkTzuLAcWFNlmgZYj1rH7xaX0RKnl RWWxBDdk9ee1d+oQ76m1r0VtBmFVSiTCMkcMslbQwvSrZkydEWB3ynWU2RYLCA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YmG702HcpzykY; Sun, 02 Feb 2025 16:58:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 512GwqF5013039; Sun, 2 Feb 2025 16:58:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 512GwqmE013036; Sun, 2 Feb 2025 16:58:52 GMT (envelope-from git) Date: Sun, 2 Feb 2025 16:58:52 GMT Message-Id: <202502021658.512GwqmE013036@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 5deab77bb6d1 - main - bce: Fix register dumping to skip blank area List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5deab77bb6d119dd171385d144a622e7ba7108fe Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=5deab77bb6d119dd171385d144a622e7ba7108fe commit 5deab77bb6d119dd171385d144a622e7ba7108fe Author: Warner Losh AuthorDate: 2025-02-02 16:49:15 +0000 Commit: Warner Losh CommitDate: 2025-02-02 16:49:15 +0000 bce: Fix register dumping to skip blank area When compiling with debug enabled, this produces an always false warning. It's clear that this was to skip ranges that aren't used when dumping the registers, so change the && to || to skip things properly. PR: 200984 Sponsored by: Netflix --- sys/dev/bce/if_bce.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/bce/if_bce.c b/sys/dev/bce/if_bce.c index 73af49015e52..b0ba56099135 100644 --- a/sys/dev/bce/if_bce.c +++ b/sys/dev/bce/if_bce.c @@ -11082,7 +11082,7 @@ bce_dump_rxp_state(struct bce_softc *sc, int regs) for (int i = BCE_RXP_CPU_MODE; i < 0xe8fff; i += 0x10) { /* Skip the big blank sapces */ - if (i < 0xc5400 && i > 0xdffff) + if (i < 0xc5400 || i > 0xdffff) BCE_PRINTF("0x%04X: 0x%08X 0x%08X " "0x%08X 0x%08X\n", i, REG_RD_IND(sc, i), @@ -11200,7 +11200,7 @@ bce_dump_cp_state(struct bce_softc *sc, int regs) for (int i = BCE_CP_CPU_MODE; i < 0x1aa000; i += 0x10) { /* Skip the big blank spaces */ - if (i < 0x185400 && i > 0x19ffff) + if (i < 0x185400 || i > 0x19ffff) BCE_PRINTF("0x%04X: 0x%08X 0x%08X " "0x%08X 0x%08X\n", i, REG_RD_IND(sc, i),