From owner-cvs-all  Thu May  2 15:59:38 2002
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id E8E1737B41A; Thu,  2 May 2002 15:59:16 -0700 (PDT)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id IAA31009;
	Fri, 3 May 2002 08:59:12 +1000
Date: Fri, 3 May 2002 09:00:38 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Alfred Perlstein <alfred@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/sys/sys socketvar.h
In-Reply-To: <200205022203.g42M3JU21259@freefall.freebsd.org>
Message-ID: <20020503085504.K5605-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Thu, 2 May 2002, Alfred Perlstein wrote:

> alfred      2002/05/02 15:03:19 PDT
>
>   Modified files:
>     sys/sys              socketvar.h
>   Log:
>   Cleanup, quote:
>
>     This leaves some vestiges of the old locking, including style
>     bugs in it.  I've only noticed anachronisms in socketvar.h so far
>     (I've merged net* but not kern or all of sys).  The patch also
>     has old fixes for style bugs in accf stuff and namespace pollution
>     in uma...  The largest style bugs are line continued backslashes
>     in column 80 and (these are fixed), and starting the do-while
>     code for the new macros in column 40, which is quite unlike the
>     usual indentation (see sys/queue.h) and not even like the indentation
>     for the old macros (column 32) (this is not fixed).
>
>   Submitted by: bde

Er, this was mailed for review and completion, not for committing almost
verbatim.  Quoted mail is rarely suitable for log messages, and the above
is no exception.  It was your commit that "leaves some vestiges of the old
locking", not this one...

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message