From owner-freebsd-net@freebsd.org  Tue Nov 29 19:05:12 2016
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4B852C5C7AD
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Tue, 29 Nov 2016 19:05:12 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (glebi.us [96.95.210.25])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 35DCD1891;
 Tue, 29 Nov 2016 19:05:11 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
 by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id uATJ5AZx051425
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Tue, 29 Nov 2016 11:05:10 -0800 (PST)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebi.us (8.15.2/8.15.2/Submit) id uATJ5A3V051424;
 Tue, 29 Nov 2016 11:05:10 -0800 (PST)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Tue, 29 Nov 2016 11:05:09 -0800
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: hiren panchasara <hiren@strugglingcoder.info>
Cc: Jakub Palider <jpa@semihalf.com>, freebsd-net@freebsd.org,
 karels@FreeBSD.org
Subject: Re: FLOWTABLE aka TCP route caching panic
Message-ID: <20161129190509.GO27748@FreeBSD.org>
References: <CAL7QUyNntDmJuxfDxncxdXSM1rvR47kizA=WYwqeAtwrSCFLUg@mail.gmail.com>
 <20161128221033.GM55731@strugglingcoder.info>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161128221033.GM55731@strugglingcoder.info>
User-Agent: Mutt/1.7.0 (2016-08-17)
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Nov 2016 19:05:12 -0000

On Mon, Nov 28, 2016 at 02:10:33PM -0800, hiren panchasara wrote:
h> > Hi,
h> > I have found that last month (19 Oct) the problem appeared on this list,
h> > and to my experience it persists, both on VM and bare metal installation
h> > (HEAD from yesterday). I looks that enabling FLOWTABLE option is the only
h> > source of this fault happening. It appears on our setup in 80% cases within
h> > one hour from boot up.
h> > From our debugging, it is caused by lock on DESTROYED lock. Did you find a
h> > solution to this problem?

Not yet.

I'm pretty sure that reverting my r307234 will fix your crashes. However, I still
believe that r307234 is a proper way of fixing things, not r300854 which just
plugged the problem in the nearest place to the crash. But as we all see r307234
is definitely missing some code path, which still allows for stale route to be
referenced.

-- 
Totus tuus, Glebius.