Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 17 Jul 2011 16:34:08 GMT
From:      David Demelier <demelier.david@gmail.com>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/158999: [patch] audio/musicpd: libsndfile auto activation feature
Message-ID:  <201107171634.p6HGY8Vx037568@red.freebsd.org>
Resent-Message-ID: <201107171640.p6HGe9nC061723@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         158999
>Category:       ports
>Synopsis:       [patch] audio/musicpd: libsndfile auto activation feature
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jul 17 16:40:09 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     David Demelier
>Release:        8.2-STABLE
>Organization:
>Environment:
FreeBSD Melon.malikania.fr 8.2-STABLE FreeBSD 8.2-STABLE #0: Sat Jul 16 10:17:29 CEST 2011     root@Melon.malikania.fr:/usr/obj/usr/src/sys/Melon  amd64

>Description:
audio/musicpd automatically links to libsndfile if the library is installed on the system. This is a autoconf feature but it also means that libsndfile will not be pulled as musicpd dependency.

This Makefile diff use a static option that links to libsndfile following the option SNDFILE enabled by default (I chose this by default but it can be discussed)


>How-To-Repeat:

>Fix:
--- musicpd.diff begins here ---
--- Makefile.orig	2011-07-17 18:24:04.000000000 +0200
+++ Makefile	2011-07-17 18:27:25.000000000 +0200
@@ -58,6 +58,7 @@
 		PULSEAUDIO	"Support PulseAudio sound server"	off \
 		JACK		"Support JACK audio server"		off \
 		SHOUTCAST	"Support for OGG Icecast and Shoutcast"	off \
+		SNDFILE		"Adds support for libsndfile"		on \
 		LAME		"Support for MP3 Icecast Streams"	off \
 		HTTPD		"Support for httpd output streaming"	off \
 		SAMPLERATE	"Support sample rate conversion"	off
@@ -224,6 +225,13 @@
 CONFIGURE_ARGS+=--disable-shout
 .endif
 
+.if defined(WITH_SNDFILE)
+LIB_DEPENDS+=	sndfile.1:${PORTSDIR}/audio/libsndfile
+CONFIGURE_ARGS+=	--enable-sndfile
+.else
+CONFIGURE_ARGS+=	--disable-sndfile
+.endif
+
 .if defined(WITHOUT_SAMPLERATE)
 CONFIGURE_ARGS+=--disable-lsr
 .else
--- musicpd.diff ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201107171634.p6HGY8Vx037568>