From owner-cvs-all@FreeBSD.ORG  Thu Oct  9 07:20:15 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 56D2516A4BF; Thu,  9 Oct 2003 07:20:15 -0700 (PDT)
Received: from ebb.errno.com (ebb.errno.com [66.127.85.87])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id A4DA743F93; Thu,  9 Oct 2003 07:20:13 -0700 (PDT)
	(envelope-from sam@errno.com)
Received: from 66.127.85.91 ([66.127.85.91])
	(authenticated bits=0)
	by ebb.errno.com (8.12.9/8.12.9) with ESMTP id h99EK80x027193
	(version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO);
	Thu, 9 Oct 2003 07:20:12 -0700 (PDT)
	(envelope-from sam@errno.com)
From: Sam Leffler <sam@errno.com>
Organization: Errno Consulting
To: Alexey Dokuchaev <danfe@nsu.ru>, Sam Leffler <sam@freebsd.org>
Date: Thu, 9 Oct 2003 07:21:06 -0700
User-Agent: KMail/1.5.3
References: <200310082352.h98Nq0ws011528@repoman.freebsd.org>
	<20031009063900.GB57459@regency.nsu.ru>
In-Reply-To: <20031009063900.GB57459@regency.nsu.ru>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200310090721.07096.sam@errno.com>
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/dev/hifn hifn7751.c hifn7751reg.h
	hifn7751var.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Oct 2003 14:20:15 -0000

On Wednesday 08 October 2003 11:33 pm, Alexey Dokuchaev wrote:
> On Wed, Oct 08, 2003 at 01:25:47PM -0700, Sam Leffler wrote:
> > sam         2003/10/08 13:25:47 PDT
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/dev/hifn         hifn7751.c hifn7751reg.h hifn7751var.h 
> >   Log:
> >   Add symmetric crypto support for the 7955 and 7956.
>
> Hmm, time to rename those hifn7751* files, or does 7751 denote something
t> hat 7955 and 7956 are based on?

The code is shared with openbsd so the filenames will not change.

On Wednesday 08 October 2003 11:39 pm, Alexey Dokuchaev wrote:
> On Wed, Oct 08, 2003 at 04:52:00PM -0700, Sam Leffler wrote:
> > sam         2003/10/08 16:52:00 PDT
> >
> >   FreeBSD src repository
> >
> >   Modified files:        (Branch: RELENG_4)
> >     sys/dev/hifn         hifn7751.c hifn7751reg.h hifn7751var.h
> >   Log:
> >   MFC 7955/7956 symmetric crypto support
>
> Hmm, had this stuff been extensively tested to be insta-MFCed,
> especially considering we're so close to 4.9-RELEASE and, just as you
> said, it's performance being currently suboptimal?

The performance of devices other than 7955 and 7956 is unchanged.  Only the 
new devices perform suboptimally.

Without these changes these devices will not work at all.  Adding the support 
now, even if suboptimal, means folks can apply a simple patch to fix the 
performance issue.

>
> I've always been under impression that -STABLE should probably stay out
> of such treatments.

I tested carefully because of this.  This driver is optional so I considered 
the risk worthwhile.

	Sam