From owner-svn-src-all@freebsd.org Thu Sep 17 19:56:37 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B2DF09CFBB4 for ; Thu, 17 Sep 2015 19:56:37 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 511931EC8 for ; Thu, 17 Sep 2015 19:56:36 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by wiclk2 with SMTP id lk2so5085910wic.1 for ; Thu, 17 Sep 2015 12:56:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:references:cc:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=F+dAswfrHRAyATRtMLG8kFzAMW+wSuQGUV0ZEbovOHI=; b=LNwgG6kk9PmZghmQFAWJUTBqg4H9qUYtBLrt2pLIpnCc8ZA3lOO5QJvc7tCmNc9u+Y FQp0oit6ZxxBZ1hFDFJbmw8U/TeIUxJ771YgsFVWlsDmUEm2kwywM4H/rSeD+kOPioqt kknQ2VB35DZHkwcdI+nbMKXoNqT7hAUZ35SjiEFC5gFAJtDV+JLdauS/JIARys711YtH 6fZt27wlgzS7+vA0RvkrAzUZxaS6K6QVFz/3EKMii4FPSBaqcS9SHzf4ikywULwfein5 J2oMgRFBelMLh9b+79hX1rI63/stQKUme9ex6F6U8MooS+SNkDxSAMM97motrCkvC7Nz 2N2g== X-Gm-Message-State: ALoCoQnNf8T7M/F//LIVb3rbBQXf+XbFNgxEcVp67EFj5ExFr3HyYOKSS7p+LNIqrJhjN+fytzoi X-Received: by 10.180.23.162 with SMTP id n2mr10810677wif.8.1442519794321; Thu, 17 Sep 2015 12:56:34 -0700 (PDT) Received: from [10.10.1.68] (82-69-141-170.dsl.in-addr.zen.co.uk. [82.69.141.170]) by smtp.gmail.com with ESMTPSA id x7sm11763775wia.10.2015.09.17.12.56.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Sep 2015 12:56:33 -0700 (PDT) From: Steven Hartland X-Google-Original-From: Steven Hartland Subject: Re: svn commit: r287886 - head/sys/sys To: Bryan Drewery , Alexey Dokuchaev References: <201509170003.t8H03uSf070155@repo.freebsd.org> <20150917081541.GA65088@FreeBSD.org> <55FAE777.4010709@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <55FB1AE9.8040804@freebsd.org> Date: Thu, 17 Sep 2015 20:56:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <55FAE777.4010709@FreeBSD.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2015 19:56:37 -0000 On 17/09/2015 17:16, Bryan Drewery wrote: > On 9/17/15 1:15 AM, Alexey Dokuchaev wrote: >> On Thu, Sep 17, 2015 at 12:03:56AM +0000, Steven Hartland wrote: >>> New Revision: 287886 >>> URL: https://svnweb.freebsd.org/changeset/base/287886 >>> >>> Log: >>> Fix kqueue write events for files > 2GB >>> >>> Due to the use of int's for file offsets in the VOP_WRITE_(PRE|POST) >>> macros, kqueue write events for files greater 2GB where never fired. >>> >>> This caused tail -f on a file greater 2GB to never see updates. >> Oh that's an embarrassing bug. >> > Please try to get an EN for this :) Yep I was going to request once the MFC timeout triggers.