From nobody Wed May 27 09:03:49 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gQNvn4H12z6fhB9 for ; Wed, 27 May 2026 09:03:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gQNvn1nM5z3XR3 for ; Wed, 27 May 2026 09:03:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779872629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9K3ZyyVkxs6PUC6kTy3XN/GBNRcoKMZJs38ARXcX8UM=; b=RPgC1AZRKEu9zg5icwTs/JRh4F5/hjRG21F+2d8R7EwmiOb54EdDDNFuPWKRWrtjBuXuz3 hqFzN9o1DR0oOXl3n/rnZPdakd0f5MHXbkPCCXGxRlYVGJT5Tq6Poak6nbGFhNY/rSmD9Y yYmahDF5XRglfcXT6KMSTr3Zl6swZC27uQ+F5eL25bzdAhAP68DShUycrcNbA1pr6pF7t5 QDj+A1dVxb2uL39Sj4MzxHpjTw1JMjb3s/BJNChgDhUH324Q0kjuT0EDhfsQDoUlWgg1Wf dypWoB+DFYlc3CNcxsXiZZTZkdtUIPZ0x9eLjK6Vpt3amTsZPfAwm5dL8WyVng== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779872629; a=rsa-sha256; cv=none; b=Hp9PKlWuysOzDauOvsRGsnDWdf0SdV9dwLMHA+sQ95eVAzOowlRhi/ed+ZCg7/SIHyHYlP nIkzwvTpAQ2tIm94P99EuC7hEmVaiddqIZeH67klyixkwU8RMT/wZqivd/UpjnISDvQyfj rYPklgKT0MS88Wr+d/KkeswARiPBsB0XECKrzlv+vITaDxC/rpYe02jLxL/XyKPE7lrCSz fb8X5VbCoJoRX594VUDw9qnhaJ/pVRFXziPg6d9cDpjq5tcebrYgLgOi47FJ0HZ8okErpF RkoNwtb7CrV48sJN8LvQvtyJf+S78PHmca5PfGW0lW2yaMtAl5/ZcqjxSCVUOQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779872629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9K3ZyyVkxs6PUC6kTy3XN/GBNRcoKMZJs38ARXcX8UM=; b=g3nvVQL0E2q5uqleYkIXzTJnvcYYn5iPRwAr+bZPrLkOuOSREgEKEogi7f+K+ErYzr6orF vf0/1KjIpyfC15Q+Bvm1tsavYQs5p4qLlvqpVkS/TI0/C47ewI8WTOy5bDVvPRIrFjhENj ChgcxgDDkaqHqOZeWgkr0NP0Lt+dv6tOhKDk5Wl45s7vz8FsLQ5afsgCpXNb+pavckbOYn Xi6NJgV19/NdQ8qWVUtyr+2crzn4eLetLURG0docz3UM1kgdxJjjdySQlwOZnVwjkS+/9B sTLscKE72F5JbGeB1MnUywbr87S0BS7naAZURIWrsaqLNq6IIRxzwxnDkAZ7Pg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gQNvn1NFWzsR0 for ; Wed, 27 May 2026 09:03:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 25add by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 27 May 2026 09:03:49 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 210bee005865 - stable/14 - tftpd: Simplify packet drop macro List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 210bee0058652662feb04379d511bcba48e04210 Auto-Submitted: auto-generated Date: Wed, 27 May 2026 09:03:49 +0000 Message-Id: <6a16b375.25add.b6ef9ea@gitrepo.freebsd.org> The branch stable/14 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=210bee0058652662feb04379d511bcba48e04210 commit 210bee0058652662feb04379d511bcba48e04210 Author: Dag-Erling Smørgrav AuthorDate: 2026-05-22 17:57:35 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-05-27 09:03:30 +0000 tftpd: Simplify packet drop macro The first argument is always the function name, for which we can simply use __func__. This leaves only the optional return value, so we can use a single variadic macro instead of two nearly-identical copies. MFC after: 1 week Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D57076 (cherry picked from commit 76c3387024b40c2e28ed2d1bb64b3a14371c3c0b) --- libexec/tftpd/tftp-io.c | 51 ++++++++++++++++++++++--------------------------- 1 file changed, 23 insertions(+), 28 deletions(-) diff --git a/libexec/tftpd/tftp-io.c b/libexec/tftpd/tftp-io.c index 8a560cbb76b0..b553bd7fa4eb 100644 --- a/libexec/tftpd/tftp-io.c +++ b/libexec/tftpd/tftp-io.c @@ -70,17 +70,12 @@ static struct errmsg { { -1, NULL } }; -#define DROPPACKET(s) \ +#define DROPPACKET(...) \ if (packetdroppercentage != 0 && \ - arc4random()%100 < packetdroppercentage) { \ - tftp_log(LOG_DEBUG, "Artificial packet drop in %s", s); \ - return; \ - } -#define DROPPACKETn(s,n) \ - if (packetdroppercentage != 0 && \ - arc4random()%100 < packetdroppercentage) { \ - tftp_log(LOG_DEBUG, "Artificial packet drop in %s", s); \ - return (n); \ + arc4random() % 100 < packetdroppercentage) { \ + tftp_log(LOG_DEBUG, "Artificial packet drop in %s", \ + __func__); \ + return __VA_ARGS__; \ } const char * @@ -105,7 +100,7 @@ send_packet(int peer, uint16_t block, char *pkt, int size) int t = 1; for (i = 0; i < 12 ; i++) { - DROPPACKETn("send_packet", 0); + DROPPACKET(0); if (sendto(peer, pkt, size, 0, (struct sockaddr *)&peer_sock, peer_sock.ss_len) == size) { @@ -145,7 +140,7 @@ send_error(int peer, int error) if (debug & DEBUG_PACKETS) tftp_log(LOG_DEBUG, "Sending ERROR %d", error); - DROPPACKET("send_error"); + DROPPACKET(); tp = (struct tftphdr *)buf; tp->th_opcode = htons((u_short)ERROR); @@ -180,12 +175,12 @@ send_wrq(int peer, char *filename, char *mode) size_t len; int n, size; - if (debug & DEBUG_PACKETS) + if (debug & DEBUG_PACKETS) { tftp_log(LOG_DEBUG, "Sending WRQ: filename: '%s', mode '%s'", - filename, mode - ); + filename, mode); + } - DROPPACKETn("send_wrq", 0); + DROPPACKET(0); tp = (struct tftphdr *)buf; tp->th_opcode = htons((u_short)WRQ); @@ -210,7 +205,7 @@ send_wrq(int peer, char *filename, char *mode) n = sendto(peer, buf, size, 0, (struct sockaddr *)&peer_sock, peer_sock.ss_len); if (n != size) { - tftp_log(LOG_ERR, "send_wrq: %s", strerror(errno)); + tftp_log(LOG_ERR, "%s: %m", __func__); return (1); } return (0); @@ -231,12 +226,12 @@ send_rrq(int peer, char *filename, char *mode) size_t len; int n, size; - if (debug & DEBUG_PACKETS) + if (debug & DEBUG_PACKETS) { tftp_log(LOG_DEBUG, "Sending RRQ: filename: '%s', mode '%s'", - filename, mode - ); + filename, mode); + } - DROPPACKETn("send_rrq", 0); + DROPPACKET(0); tp = (struct tftphdr *)buf; tp->th_opcode = htons((u_short)RRQ); @@ -263,7 +258,7 @@ send_rrq(int peer, char *filename, char *mode) n = sendto(peer, buf, size, 0, (struct sockaddr *)&peer_sock, peer_sock.ss_len); if (n != size) { - tftp_log(LOG_ERR, "send_rrq: %d %s", n, strerror(errno)); + tftp_log(LOG_ERR, "%s: %m", __func__); return (1); } return (0); @@ -286,7 +281,7 @@ send_oack(int peer) if (debug & DEBUG_PACKETS) tftp_log(LOG_DEBUG, "Sending OACK"); - DROPPACKETn("send_oack", 0); + DROPPACKET(0); /* * Send back an options acknowledgement (only the ones with @@ -300,8 +295,8 @@ send_oack(int peer) if (options[i].o_reply != NULL) { n = snprintf(bp, size, "%s%c%s", options[i].o_type, 0, options[i].o_reply); - bp += n+1; - size -= n+1; + bp += n + 1; + size -= n + 1; if (size < 0) { tftp_log(LOG_ERR, "oack: buffer overflow"); exit(1); @@ -332,7 +327,7 @@ send_ack(int fp, uint16_t block) if (debug & DEBUG_PACKETS) tftp_log(LOG_DEBUG, "Sending ACK for block %d", block); - DROPPACKETn("send_ack", 0); + DROPPACKET(0); tp = (struct tftphdr *)buf; tp->th_opcode = htons((u_short)ACK); @@ -362,7 +357,7 @@ send_data(int peer, uint16_t block, char *data, int size) tftp_log(LOG_DEBUG, "Sending DATA packet %d of %d bytes", block, size); - DROPPACKETn("send_data", 0); + DROPPACKET(0); pkt = (struct tftphdr *)buf; @@ -409,7 +404,7 @@ receive_packet(int peer, char *data, int size, struct sockaddr_storage *from, fromlen = sizeof(*pfrom); n = recvfrom(peer, data, size, 0, (struct sockaddr *)pfrom, &fromlen); - DROPPACKETn("receive_packet", RP_TIMEOUT); + DROPPACKET(RP_TIMEOUT); if (n < 0) { /* No idea what could have happened if it isn't a timeout */