From owner-freebsd-net@freebsd.org Thu Aug 24 09:55:56 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 26917DDB7D9 for ; Thu, 24 Aug 2017 09:55:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 075C6722D7 for ; Thu, 24 Aug 2017 09:55:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v7O9ttmN011028 for ; Thu, 24 Aug 2017 09:55:55 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 220198] igb stats double counting in 12-CURRENT Date: Thu, 24 Aug 2017 09:55:56 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: IntelNetworking X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: kaho@elam.kais.kyoto-u.ac.jp X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Aug 2017 09:55:56 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220198 Kaho Toshikazu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kaho@elam.kais.kyoto-u.ac.j | |p --- Comment #3 from Kaho Toshikazu --- (In reply to commit-hook from comment #1) I think the bug is fixed by this commit, but it is not a good way. 1. Every driver using iflib should set IFCAP_HWSTATS flag within the driver. For example, in the em(4) driver, add IFCAP_HWSTATS flag into #define EM_CAPS and #define IGB_CAPS lines of if_em.c. 2. The IFCAP_FLAGS in iflib.c seems to hold flags which can be changed by a ioctl function. Who want to set or unset the IFCAP_HWSTATS flag by a function? --=20 You are receiving this mail because: You are the assignee for the bug.=