From owner-freebsd-current@FreeBSD.ORG  Wed Aug 11 22:27:05 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5F44D16A4CE; Wed, 11 Aug 2004 22:27:05 +0000 (GMT)
Received: from harmony.village.org (rover.village.org [168.103.84.182])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 0118343D45; Wed, 11 Aug 2004 22:27:05 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.11/8.12.11) with ESMTP id i7BMQUMM096565;
	Wed, 11 Aug 2004 16:26:31 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Wed, 11 Aug 2004 16:26:40 -0600 (MDT)
Message-Id: <20040811.162640.00482545.imp@bsdimp.com>
To: ru@freebsd.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20040811221348.GB93983@ip.net.ua>
References: <20040810231044.GA70020@xor.obsecurity.org>
	<20040811.160420.34008155.imp@bsdimp.com>
	<20040811221348.GB93983@ip.net.ua>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: harti@freebsd.org
cc: current@freebsd.org
cc: kris@obsecurity.org
Subject: Re: World broken in stage 1.1
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Aug 2004 22:27:05 -0000

In message: <20040811221348.GB93983@ip.net.ua>
            Ruslan Ermilov <ru@FreeBSD.org> writes:
: On Wed, Aug 11, 2004 at 04:04:20PM -0600, M. Warner Losh wrote:
: > In message: <20040810231044.GA70020@xor.obsecurity.org>
: >             Kris Kennaway <kris@obsecurity.org> writes:
: > : More fallout from the wonderful new make(1) semantics? 
: > 
: > I think it is speficially related to the changes to src/Makefile and
: > src/Makefile.inc1.  If I s/${_+_}//g on those two files, it appears
: > that I can buildworld again (at least it doesn't die right away).
: > 
: How exactly does it die for you, please provide some logs.

The problem is due to the following in share/mk/sys.mk:

.if !empty(.MAKEFLAGS:M-n) && ${.MAKEFLAGS:M-n} == "-n"
_+_             ?=
.else
_+_             ?=      +
.endif

This should have a third clause:

.if ${MAKE_VERSION} >= 5200408030 && !empty(.MAKEFLAGS:M-n) && ${.MAKEFLAGS:M-n} == "-n"

so that _+_ is defined to be nothing for those versions of make that
don't yet support this new feature of posix.

Warner