From nobody Wed Jul 8 12:28:20 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gwHSV4RPPz6lGvS for ; Wed, 08 Jul 2026 12:28:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gwHSV0zJZz3ZLK for ; Wed, 08 Jul 2026 12:28:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783513706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eL7YK/RmG70GUpPru4A/IRhBDmWfVWzVB9sQ+CWYhes=; b=dlUN5bTLMQ0hAOpieTL5a2ingwdDObIZSUVnhiJv6JVwGXZT93cIFoNyBjjFZ5bDvryuv6 0cSruTimNABp4Oa/xU8wJpiEXZe7ny933CQRzGNHAho1kizeD+Aut7W0QFVCfqFO5kptA/ a7zV2vXqzrmOQy+eTk19cnoG5XksWljBE0WlbCFsM2NUgwf6Q0ocjfMRYyvpz08Q7zrkTA HQep6CIn/pnFj53T9yaz+pX6cXMURVXQQbJ01xl8yjQDocSX3dkq8zNOxnHtRLPJP8T/Ua Aap0XvkN1JuDYaOVKBwjKG+kZ2B7tlWevyb4cZHQ5Pivcmk8kdr6emE+7B+t4A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783513706; a=rsa-sha256; cv=none; b=LexkDaz1H3/2et9wBA4NzocA8FGb+mx8ZImPvTa3os/1p4r24X2zBQVixWJp9zYW+zNqcW Pw6gmzpwglDvhZ2OWP9ouMNWYcKA8NdxfI15Ji1IYyrpHJgG9e5OIYmOqsxV48HSf0EBl0 HfNj54vizMhBBCArW9wSoSiYek5moTVeK/dBXRQfdYCOBf+1l6c4hRVuv8RSv5rgHr0PIm 5hfjK/ja51iOoHvhEyl4t2t6/U1573V23N7Dntpqzdx15Daj+zRh2iBtB7kDBxm65CEZPn 3wsgcFDPDoT5H72jwJb4dERfHmP83QWYc9XUQ6z1HSE/aYrlhjVoGgzpCewu/w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783513706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eL7YK/RmG70GUpPru4A/IRhBDmWfVWzVB9sQ+CWYhes=; b=JMxjP1jDywsTCvbwG40JxCYizlJMbzvNzkFio4Q7YEahsq/LgMY+ir5XwTsJLisvE5EOwQ AnB8BsoQfG8J+5gLFlsmCNgpfYzTotfW48U9vBurGNDhAax2xZPqr/hpJ53B/lE98ZHbUI rYjqPq0mDREM78uWtDK4wfoNMYoa4JTVraEddeAuuo6YfsIBCynLLKfKFGu3ew+1XYnujQ as1P3jmW5lUNbz/8cn0ycbg5SXIDfeoJ8Nz5vhp9GI/lLwFq35CJT2b8if88w56/vXE9nz Gv/GBS3uYg8gTmaC0OvOYqZXmoXTC47JyiA7Qu+U1zG7nP0toQn7BBw0jiLn7w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gwHST6tBrz62h for ; Wed, 08 Jul 2026 12:28:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3c2ad by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 08 Jul 2026 12:28:20 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Gallatin Subject: git: 1cce5ef05d7b - main - lagg: re-check port caps after bringing up a port List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gallatin X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1cce5ef05d7ba077b0cb29d30b59f3a862e7e5ae Auto-Submitted: auto-generated Date: Wed, 08 Jul 2026 12:28:20 +0000 Message-Id: <6a4e4264.3c2ad.53e50a88@gitrepo.freebsd.org> The branch main has been updated by gallatin: URL: https://cgit.FreeBSD.org/src/commit/?id=1cce5ef05d7ba077b0cb29d30b59f3a862e7e5ae commit 1cce5ef05d7ba077b0cb29d30b59f3a862e7e5ae Author: Andrew Gallatin AuthorDate: 2026-07-08 12:24:35 +0000 Commit: Andrew Gallatin CommitDate: 2026-07-08 12:27:58 +0000 lagg: re-check port caps after bringing up a port Some nic drivers (including iflib) do not initialize if_hwassist until after the interface is brought up. If a lagg member is included in a lagg when its not yet been brought up, that will cause lagg to see if_hwassist=0 and will disable all checksum offload, etc, on the interface. This is almost impossible to debug without kgdb or dtrace, as ifconfig does not surface if_hwassist. Fix this by re-calculating lagg caps (including if_hwassist) after adding a port. I encountered this problem when I had a commented-out if_foo1=up entry in my rc.conf that i neglected to uncomment when I was re-configuring a lagg. Sponsored by: Netflix Reviewed by: markj, zlei Differential Revision: https://reviews.freebsd.org/D58062 --- sys/net/if_lagg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/net/if_lagg.c b/sys/net/if_lagg.c index da08e02d50be..e8e0306b0d1f 100644 --- a/sys/net/if_lagg.c +++ b/sys/net/if_lagg.c @@ -1309,6 +1309,8 @@ lagg_init_locked(struct lagg_softc *sc) lagg_if_updown(sc, true); + /* Recheck port caps; bringing them up may have changed if_hwassist. */ + lagg_capabilities(sc); lagg_proto_init(sc); if (ifp->if_type == IFT_INFINIBAND) {