From owner-freebsd-eclipse@FreeBSD.ORG Tue Aug 26 19:40:24 2008 Return-Path: Delivered-To: freebsd-eclipse@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1E378106566B for ; Tue, 26 Aug 2008 19:40:24 +0000 (UTC) (envelope-from rick@kiwi-computer.com) Received: from kiwi-computer.com (keira.kiwi-computer.com [63.224.10.3]) by mx1.freebsd.org (Postfix) with SMTP id 923018FC1E for ; Tue, 26 Aug 2008 19:40:23 +0000 (UTC) (envelope-from rick@kiwi-computer.com) Received: (qmail 37643 invoked by uid 2001); 26 Aug 2008 19:13:41 -0000 Date: Tue, 26 Aug 2008 14:13:41 -0500 From: "Rick C. Petty" To: freebsd-eclipse@freebsd.org Message-ID: <20080826191341.GA37568@keira.kiwi-computer.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.3i Subject: wrong JAVA_VENDOR X-BeenThere: freebsd-eclipse@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: rick-freebsd2008@kiwi-computer.com List-Id: "FreeBSD users of eclipse EDI, tools, rich client apps & ports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Aug 2008 19:40:24 -0000 If you install java/diablo-jdk16 instead of java/jdk16, the JAVA_VENDOR is "freebsd". The java/eclipse Makefile sets JAVA_VENDOR to "bsdjava". Why is this? This makes it so that you cannot run eclipse with only diablo-jdk16 installed. Why is it even being set? Isn't it enough that we use JAVA_OS=native ??? I suggest the following patch: --- ports/java/eclipse/Makefile.orig 2008-08-14 19:17:21.000000000 -0500 +++ ports/java/eclipse/Makefile 2008-08-26 19:13:03.000000000 -0500 @@ -60,10 +60,6 @@ .include -.if ${OSVERSION} >= 700000 -JAVA_VENDOR= bsdjava -.endif - .if !defined(WITHOUT_MOZILLA) MAKE_MOZILLA= make_mozilla BROWSER= ${GECKO} -- Rick C. Petty