From owner-freebsd-stable@FreeBSD.ORG Mon Oct 22 15:42:16 2012 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 79A951C5; Mon, 22 Oct 2012 15:42:16 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 4ACA58FC0A; Mon, 22 Oct 2012 15:42:16 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id B0CB4B91A; Mon, 22 Oct 2012 11:42:15 -0400 (EDT) From: John Baldwin To: freebsd-stable@freebsd.org Subject: Re: ${CTFCONVERT_CMD} expands to empty string Date: Mon, 22 Oct 2012 11:42:06 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p20; KDE/4.5.5; amd64; ; ) References: <5081F92F.8040004@freebsd.org> <508317A4.2060800@freebsd.org> <5084927C.1070101@freebsd.org> In-Reply-To: <5084927C.1070101@freebsd.org> MIME-Version: 1.0 Message-Id: <201210221142.06889.jhb@freebsd.org> Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 22 Oct 2012 11:42:15 -0400 (EDT) Cc: stable@freebsd.org, Andrey Chernov X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2012 15:42:16 -0000 On Sunday, October 21, 2012 8:25:32 pm Andrey Chernov wrote: > Those lines cause this error: > .if ${MK_CTF} != "no" > CTFCONVERT_CMD= ${CTFCONVERT} ${CTFFLAGS} ${.TARGET} > .elif ${MAKE_VERSION} >= 5201111300 > CTFCONVERT_CMD= > .else > CTFCONVERT_CMD= @: > .endif > > My make version is 9201206140 > So, either the check for >= 5201111300 is incorrect or change for empty > make variables expansion is not merged into stable-9 I can't reproduce this doing a buildworld of a stable/9 checkout on a 9.0- stable machine btw. What exact contents of /etc/src.conf and commands are you using to reproduce this? I also can't find the string "empty string" in the output of my stable/9 'make universe' build before I committed this. -- John Baldwin