From owner-svn-src-all@FreeBSD.ORG  Thu Aug 22 18:32:46 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 67C6FC63;
 Thu, 22 Aug 2013 18:32:46 +0000 (UTC) (envelope-from mike@sentex.net)
Received: from smarthost1.sentex.ca (smarthost1-6.sentex.ca
 [IPv6:2607:f3e0:0:1::12])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id BA38F23BD;
 Thu, 22 Aug 2013 18:32:45 +0000 (UTC)
Received: from [192.168.43.26] (pyroxene.sentex.ca [199.212.134.18])
 by smarthost1.sentex.ca (8.14.5/8.14.5) with ESMTP id r7MIWg5R074022;
 Thu, 22 Aug 2013 14:32:43 -0400 (EDT) (envelope-from mike@sentex.net)
Message-ID: <52165936.60503@sentex.net>
Date: Thu, 22 Aug 2013 14:32:22 -0400
From: Mike Tancsa <mike@sentex.net>
Organization: Sentex Communications
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To: =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= <des@des.no>
Subject: Re: svn commit: r254626 - stable/9/usr.bin/yacc
References: <201308212257.r7LMvUmY053608@svn.freebsd.org>
 <8638q2i1oo.fsf@nine.des.no> <86y57ugn00.fsf@nine.des.no>
 <20130822213005.H1824@besplex.bde.org> <864naios6h.fsf@nine.des.no>
In-Reply-To: <864naios6h.fsf@nine.des.no>
X-Enigmail-Version: 1.4.2
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Scanned-By: MIMEDefang 2.74 on 64.7.153.18
Cc: src-committers@freebsd.org, svn-src-stable@freebsd.org,
 svn-src-all@freebsd.org, svn-src-stable-9@freebsd.org,
 "David E. O'Brien" <obrien@freebsd.org>, Bruce Evans <brde@optusnet.com.au>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Aug 2013 18:32:46 -0000

On 8/22/2013 7:56 AM, Dag-Erling Smørgrav wrote:
> 
> So what do you suggest?  Revert David's change, or keep it (minus
> extern) and remove the prototype from expr.y?
> 
> I favor the latter option, since yyparse() is auto-generated and expr.y
> can therefore (strictly speaking) not know what the correct prototype
> looks like.


Is it safe to buildworld with this change ?

	---Mike


-- 
-------------------
Mike Tancsa, tel +1 519 651 3400
Sentex Communications, mike@sentex.net
Providing Internet services since 1994 www.sentex.net
Cambridge, Ontario Canada   http://www.tancsa.com/