From owner-freebsd-ports Thu Apr 18 8:57:48 2002 Delivered-To: freebsd-ports@freebsd.org Received: from sdns.kv.ukrtel.net (sdns.kv.ukrtel.net [195.5.27.246]) by hub.freebsd.org (Postfix) with ESMTP id CD04337B417; Thu, 18 Apr 2002 08:57:42 -0700 (PDT) Received: from vega.vega.com (195.5.51.243 [195.5.51.243]) by sdns.kv.ukrtel.net with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2650.21) id JFW89BZW; Thu, 18 Apr 2002 18:59:15 +0300 Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1]) by vega.vega.com (8.11.6/8.11.3) with ESMTP id g3IFwjx49021; Thu, 18 Apr 2002 18:58:45 +0300 (EEST) (envelope-from sobomax@FreeBSD.org) Message-ID: <3CBEED61.AFF1C3BC@FreeBSD.org> Date: Thu, 18 Apr 2002 18:59:29 +0300 From: Maxim Sobolev Organization: Vega International Capital X-Mailer: Mozilla 4.79 [en] (Windows NT 5.0; U) X-Accept-Language: en,uk,ru MIME-Version: 1.0 To: obrien@FreeBSD.ORG Cc: ports@FreeBSD.ORG Subject: Re: Tools/scripts/patchtool.py References: <20020418080638.A86691@dragon.nuxi.com> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org David O'Brien wrote: > > Are you the owner of this file such that others cannot commit to it? > I want to make this commit. My justification is that '/' in path names > of the file being patch are turned into _four_ characters by shell's > autocompletion -- "\:\:" which makes patches very long. > > I also do not understand why every patch in ports/java/jdk13/files is > named "patch-.." by your script (ie, why the ..). But maybe we can work > on that next. Making a few changes will make living with these silly > paths easier as at least they will fit on a single 80 character line in > an ls listing. > > Index: patchtool.py > =================================================================== > RCS file: /home/ncvs/ports/Tools/scripts/patchtool.py,v > retrieving revision 1.9 > diff -u -r1.9 patchtool.py > --- patchtool.py 17 Apr 2002 10:58:57 -0000 1.9 > +++ patchtool.py 18 Apr 2002 15:02:16 -0000 > @@ -50,8 +50,8 @@ > DEV_NULL = '/dev/null' > ETC_MAKE_CONF = '/etc/make.conf' > > - SLASH_REPL_SYMBOL = '::' # The sysmbol to replace '/' when auto-generating > - # patchnames > + SLASH_REPL_SYMBOL = '_' # The sysmbol to replace '/' when > + # auto-generating patchnames Approved, but please leave the comment alone - the file assumes 4-spaces tabs. Thanks! -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message