From owner-cvs-all@FreeBSD.ORG Thu Dec 8 13:30:35 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F152F16A41F; Thu, 8 Dec 2005 13:30:34 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id ED75C43D62; Thu, 8 Dec 2005 13:30:20 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.ntplx.net (8.13.5/8.13.5/NETPLEX) with ESMTP id jB8DTwSo011222; Thu, 8 Dec 2005 08:29:58 -0500 (EST) Date: Thu, 8 Dec 2005 08:29:57 -0500 (EST) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: David Xu In-Reply-To: <4397BB3B.2010008@freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net) Cc: Scott Long , src-committers@freebsd.org, Doug Ambrisko , John Baldwin , cvs-src@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys signal.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Dec 2005 13:30:35 -0000 On Thu, 8 Dec 2005, David Xu wrote: > Daniel Eischen wrote: > > I was going to do it in libc so it doesn't have to be done by each > > thread library. > > > > But there are still aio_* syscalls that haven't been changed to have > > compat syscalls. You did aio_read, aio_write, and lio_listion, but > > not aio_error, aio_return, aio_suspend, aio_cancel, and aio_waitcomplete. > > I think these really need compat syscalls due to the different layout of > > struct sigevent (because it affects layout of struct aiocb). > > > The aio_error, aio_return and other syscalls don't access sigevent, > they all access kernel private data of aiocb, I left old sigevent space > there, but will not be used by new syscalls, the new sigevent is > appended at end of aiocb, offset of kernel private data area is not changed. So we're OK then since you've already added compat syscalls. Only -current users need to recompile. -- DE